From: "Nambiar, Amritha" <amritha.nambiar@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<sridhar.samudrala@intel.com>
Subject: Re: [net-next PATCH v1 5/9] netdev-genl: Add netlink framework functions for napi
Date: Mon, 31 Jul 2023 16:01:01 -0700 [thread overview]
Message-ID: <7554b924-3c09-596a-af11-f3d309bd2d19@intel.com> (raw)
In-Reply-To: <20230731123732.5e112027@kernel.org>
On 7/31/2023 12:37 PM, Jakub Kicinski wrote:
> On Fri, 28 Jul 2023 17:47:17 -0700 Amritha Nambiar wrote:
>> int netdev_nl_napi_get_dumpit(struct sk_buff *skb, struct netlink_callback *cb)
>> {
>> - return -EOPNOTSUPP;
>> + struct netdev_nl_dump_ctx *ctx = netdev_dump_ctx(cb);
>> + struct net *net = sock_net(skb->sk);
>> + struct net_device *netdev;
>> + int idx = 0, s_idx, n_idx;
>> + int h, s_h;
>> + int err;
>> +
>> + s_h = ctx->dev_entry_hash;
>> + s_idx = ctx->dev_entry_idx;
>> + n_idx = ctx->napi_idx;
>> +
>> + rtnl_lock();
>> +
>> + for (h = s_h; h < NETDEV_HASHENTRIES; h++, s_idx = 0) {
>> + struct hlist_head *head;
>> +
>> + idx = 0;
>> + head = &net->dev_index_head[h];
>> + hlist_for_each_entry(netdev, head, index_hlist) {
>
> Please rebased on latest net-next you can ditch all this iteration
> stuff and use the new xarray.
Sure, will fix in the next version.
next prev parent reply other threads:[~2023-07-31 23:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-29 0:46 [net-next PATCH v1 0/9] Introduce NAPI queues support Amritha Nambiar
2023-07-29 0:46 ` [net-next PATCH v1 1/9] net: Introduce new fields for napi and queue associations Amritha Nambiar
2023-07-29 9:55 ` kernel test robot
2023-07-30 17:10 ` Simon Horman
2023-07-31 22:57 ` Nambiar, Amritha
2023-07-29 0:47 ` [net-next PATCH v1 2/9] ice: Add support in the driver for associating napi with queue[s] Amritha Nambiar
2023-07-29 0:47 ` [net-next PATCH v1 3/9] netdev-genl: spec: Extend netdev netlink spec in YAML for NAPI Amritha Nambiar
2023-07-31 19:36 ` Jakub Kicinski
2023-07-31 23:12 ` Nambiar, Amritha
2023-08-01 0:13 ` Jakub Kicinski
2023-08-01 0:24 ` Nambiar, Amritha
2023-08-01 0:35 ` Jakub Kicinski
2023-08-09 0:17 ` Nambiar, Amritha
2023-08-09 2:45 ` Jakub Kicinski
2023-07-29 0:47 ` [net-next PATCH v1 4/9] net: Move kernel helpers for queue index outside sysfs Amritha Nambiar
2023-07-29 0:47 ` [net-next PATCH v1 5/9] netdev-genl: Add netlink framework functions for napi Amritha Nambiar
2023-07-30 17:15 ` Simon Horman
2023-07-31 23:00 ` Nambiar, Amritha
2023-07-31 19:37 ` Jakub Kicinski
2023-07-31 23:01 ` Nambiar, Amritha [this message]
2023-07-29 0:47 ` [net-next PATCH v1 6/9] netdev-genl: spec: Add irq in netdev netlink YAML spec Amritha Nambiar
2023-07-29 0:47 ` [net-next PATCH v1 7/9] net: Add NAPI IRQ support Amritha Nambiar
2023-07-29 4:05 ` Stephen Hemminger
2023-07-31 23:22 ` Nambiar, Amritha
2023-07-29 0:47 ` [net-next PATCH v1 8/9] netdev-genl: spec: Add PID in netdev netlink YAML spec Amritha Nambiar
2023-07-29 0:47 ` [net-next PATCH v1 9/9] netdev-genl: Add PID for the NAPI thread Amritha Nambiar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7554b924-3c09-596a-af11-f3d309bd2d19@intel.com \
--to=amritha.nambiar@intel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).