From: Amber Chen <amber.chen@realtek.com>
To: Prashant Malani <pmalani@chromium.org>
Cc: Hayes Wang <hayeswang@realtek.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Bambi Yeh <bambi.yeh@realtek.com>, Ryankao <ryankao@realtek.com>,
Jackc <jackc@realtek.com>, Albertk <albertk@realtek.com>,
"marcochen@google.com" <marcochen@google.com>,
nic_swsd <nic_swsd@realtek.com>,
Grant Grundler <grundler@chromium.org>
Subject: Re: Proposal: r8152 firmware patching framework
Date: Sat, 31 Aug 2019 00:53:35 +0000 [thread overview]
Message-ID: <755AFD2B-D66F-40FF-ADCD-5077ECC569FE@realtek.com> (raw)
In-Reply-To: <CACeCKacjCkS5UmzS9irm0JjGmk98uBBBsTLSzrXoDUJ60Be9Vw@mail.gmail.com>
+ acct mgr, Stephen
> Prashant Malani <pmalani@chromium.org> 於 2019年8月31日 上午6:24 寫道：
>
> (Adding a few more Realtek folks)
>
> Friendly ping. Any thoughts / feedback, Realtek folks (and others) ?
>
>> On Thu, Aug 29, 2019 at 11:40 AM Prashant Malani <pmalani@chromium.org> wrote:
>>
>> Hi,
>>
>> The r8152 driver source code distributed by Realtek (on
>> www.realtek.com) contains firmware patches. This involves binary
>> byte-arrays being written byte/word-wise to the hardware memory
>> Example: grundler@chromium.org (cc-ed) has an experimental patch which
>> includes the firmware patching code which was distributed with the
>> Realtek source :
>> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1417953
>>
>> It would be nice to have a way to incorporate these firmware fixes
>> into the upstream code. Since having indecipherable byte-arrays is not
>> possible upstream, I propose the following:
>> - We use the assistance of Realtek to come up with a format which the
>> firmware patch files can follow (this can be documented in the
>> comments).
>> - A real simple format could look like this:
>> +
>> <section1><size_in_bytes><address1><data1><address2><data2>...<addressN><dataN><section2>...
>> + The driver would be able to understand how to parse
>> each section (e.g is each data entry a byte or a word?)
>>
>> - We use request_firmware() to load the firmware, parse it and write
>> the data to the relevant registers.
>>
>> I'm unfamiliar with what the preferred method of firmware patching is,
>> so I hope the maintainers can help suggest the best path forward.
>>
>> As an aside: It would be great if Realtek could publish a list of
>> fixes that the firmware patches implement (I think a list on the
>> driver download page on the Realtek website would be an excellent
>> starting point).
>>
>> Thanks and Best regards,
>>
>> -Prashant
>
> ------Please consider the environment before printing this e-mail.
next prev parent reply other threads:[~2019-08-31 0:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 18:40 Proposal: r8152 firmware patching framework Prashant Malani
2019-08-30 22:24 ` Prashant Malani
2019-08-31 0:53 ` Amber Chen [this message]
2019-09-02 6:31 ` Hayes Wang
2019-09-03 9:01 ` Bambi Yeh
2019-09-03 21:32 ` Prashant Malani
2019-09-03 22:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=755AFD2B-D66F-40FF-ADCD-5077ECC569FE@realtek.com \
--to=amber.chen@realtek.com \
--cc=albertk@realtek.com \
--cc=bambi.yeh@realtek.com \
--cc=davem@davemloft.net \
--cc=grundler@chromium.org \
--cc=hayeswang@realtek.com \
--cc=jackc@realtek.com \
--cc=marcochen@google.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pmalani@chromium.org \
--cc=ryankao@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox