Re: [PATCH net-next] net: hsr: emit notification for PRP slave2 changed hw addr on port deletion

Fernando Fernandez Mancera
2026-04-07T13:37:23Z

On 4/7/26 3:29 PM, Paolo Abeni wrote:
> On 4/3/26 2:39 PM, Fernando Fernandez Mancera wrote:
>> On PRP protocol, when deleting the port the MAC address change
>> notification was missing. In addition to that, make sure to only perform
>> the MAC address change on slave2 deletion and PRP protocol as the
>> operation isn't necessary for HSR nor slave1.
>>
>> Note that the eth_hw_addr_set() is correct on PRP context as the slaves
>> are either in promiscuous mode or forward offload enabled.
>>
>> Fixes: b65999e7238e ("net: hsr: sync hw addr of slave2 according to slave1 hw addr on PRP")
>> Reported-by: Luka Gejak <luka.gejak@linux.dev>
>> Closes: https://lore.kernel.org/netdev/DHFCZEM93FTT.1RWFBIE32K7OT@linux.dev/
>> Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de>
>> ---
>> Note: routed through net-next tree as the next net tree as rc6 batch is
>> already out and I do not think this is worth to be included in a last
>> call batch. Anyway, if maintainer thinks it is, feel free to apply it to
>> net tree.
>
> The general guidance is to avoid fixes tag for net-next patches that do
> not fix net-next specific code. In this case I assume you want the patch
> landing into stable right?
>

Hi Paolo,

Noted. I wanted to reduce the number of patches on net tree given we are
at the end of the development cycle. To be honest, the stable backport
isn't that important here, this is a trivial fix that I doubt it was
breaking anyone.

Maybe drop Fixes tag and get it into net-next then? Fine for me anyway,
I trust your judgement on this.

Thanks,
Fernando.

> I think a net target would be better, please LMK.
>
> /P
>