From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Paolo Abeni <pabeni@redhat.com>,
Vadim Fedorenko <vadfed@meta.com>,
Jakub Kicinski <kuba@kernel.org>,
David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Alexander Duyck <alexanderduyck@fb.com>
Cc: netdev@vger.kernel.org, Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH net-next v4 1/5] eth: fbnic: add software TX timestamping support
Date: Thu, 10 Oct 2024 11:49:46 +0100 [thread overview]
Message-ID: <759dbb55-cc60-439e-9f7b-c04554e565dd@linux.dev> (raw)
In-Reply-To: <3f190185-4143-4a0f-af36-eab2ecbfe670@redhat.com>
On 10/10/2024 11:38, Paolo Abeni wrote:
> On 10/10/24 12:18, Paolo Abeni wrote:
>> On 10/8/24 20:14, Vadim Fedorenko wrote:
>>> diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c b/
>>> drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c
>>> index 5d980e178941..ffc773014e0f 100644
>>> --- a/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c
>>> +++ b/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c
>>> @@ -6,6 +6,16 @@
>>> #include "fbnic_netdev.h"
>>> #include "fbnic_tlv.h"
>>> +static int
>>> +fbnic_get_ts_info(struct net_device *netdev,
>>> + struct kernel_ethtool_ts_info *tsinfo)
>>> +{
>>> + tsinfo->so_timestamping =
>>> + SOF_TIMESTAMPING_TX_SOFTWARE;
>>
>> Only if you need to repost for some other reasons: the above could use a
>> single line.
>
> Never mind, I see the changes in patch 3 now...
Yep, the next patches will change this line..
next prev parent reply other threads:[~2024-10-10 10:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 18:14 [PATCH net-next v4 0/5] eth: fbnic: add timestamping support Vadim Fedorenko
2024-10-08 18:14 ` [PATCH net-next v4 1/5] eth: fbnic: add software TX " Vadim Fedorenko
2024-10-10 10:18 ` Paolo Abeni
2024-10-10 10:38 ` Paolo Abeni
2024-10-10 10:49 ` Vadim Fedorenko [this message]
2024-10-08 18:14 ` [PATCH net-next v4 2/5] eth: fbnic: add initial PHC support Vadim Fedorenko
2024-10-08 18:14 ` [PATCH net-next v4 3/5] eth: fbnic: add RX packets timestamping support Vadim Fedorenko
2024-10-08 18:14 ` [PATCH net-next v4 4/5] eth: fbnic: add TX " Vadim Fedorenko
2024-10-08 18:14 ` [PATCH net-next v4 5/5] eth: fbnic: add ethtool timestamping statistics Vadim Fedorenko
2024-10-10 11:00 ` [PATCH net-next v4 0/5] eth: fbnic: add timestamping support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=759dbb55-cc60-439e-9f7b-c04554e565dd@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=alexanderduyck@fb.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vadfed@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).