From: Dan Carpenter <dan.carpenter@linaro.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com,
jiawenwu@trustnetic.com, mengyuanlou@net-swift.com,
yang.lee@linux.alibaba.com, error27@gmail.com,
linyunsheng@huawei.com, linux-hyperv@vger.kernel.org,
kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, longli@microsoft.com,
shradhagupta@linux.microsoft.com, linux-hwmon@vger.kernel.org,
michael.chan@broadcom.com, richardcochran@gmail.com,
jdelvare@suse.com, linux@roeck-us.net, yisen.zhuang@huawei.com,
salil.mehta@huawei.com, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, nbd@nbd.name,
john@phrozen.org, sean.wang@mediatek.com,
Mark-MC.Lee@mediatek.com, lorenzo@kernel.org,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
linux@armlinux.org.uk, linux-rdma@vger.kernel.org,
saeedm@nvidia.com, leon@kernel.org,
gerhard@engleder-embedded.com, maciej.fijalkowski@intel.com,
alexanderduyck@fb.com, wei.fang@nxp.com, shenwei.wang@nxp.com,
xiaoning.wang@nxp.com, linux-imx@nxp.com, lgirdwood@gmail.com,
broonie@kernel.org, jaswinder.singh@linaro.org,
ilias.apalodimas@linaro.org, UNGLinuxDriver@microchip.com,
horatiu.vultur@microchip.com, linux-omap@vger.kernel.org,
grygorii.strashko@ti.com, simon.horman@corigine.com,
vladimir.oltean@nxp.com, aleksander.lobakin@intel.com,
linux-stm32@st-md-mailman.stormreply.com,
alexandre.torgue@foss.st.com, joabreu@synopsys.com,
mcoquelin.stm32@gmail.com, p.zabel@pengutronix.de,
thomas.petazzoni@bootlin.com, mw@semihalf.com,
sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com,
hkelam@marvell.com, xen-devel@lists.xenproject.org,
jgross@suse.com, sstabellini@kernel.org,
oleksandr_tyshchenko@epam.com, linux-wireless@vger.kernel.org,
ryder.lee@mediatek.com, shayne.chen@mediatek.com,
kvalo@kernel.org, andrii@kernel.org, martin.lau@linux.dev,
song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org,
sdf@google.com, haoluo@google.com, jolsa@kernel.org
Subject: Re: [PATCH v1 net] page_pool: Cap queue size to 32k.
Date: Tue, 5 Sep 2023 12:57:34 +0300 [thread overview]
Message-ID: <75bcd331-9a62-486f-a15f-6aebf4d1838b@kadam.mountain> (raw)
In-Reply-To: <20230814060411.2401817-1-rkannoth@marvell.com>
On Mon, Aug 14, 2023 at 11:34:11AM +0530, Ratheesh Kannoth wrote:
> Clamp to 32k instead of returning error.
What is the motivation here? What is the real world impact for the
users?
>
> Please find discussion at
> https://lore.kernel.org/lkml/
> CY4PR1801MB1911E15D518A77535F6E51E2D308A@CY4PR1801MB1911.
> namprd18.prod.outlook.com/T/
Please don't break the URL up like this. I think normally we would just
write up a normal commit message and use the Link: tag.
Fixes: ff7d6b27f894 ("page_pool: refurbish version of page_pool code")
Link: https://lore.kernel.org/lkml/CY4PR1801MB1911E15D518A77535F6E51E2D308A@CY4PR1801MB1911.namprd18.prod.outlook.com/
Signed-off-by:
> @@ -171,9 +171,10 @@ static int page_pool_init(struct page_pool *pool,
> if (pool->p.pool_size)
> ring_qsize = pool->p.pool_size;
>
> - /* Sanity limit mem that can be pinned down */
> + /* Cap queue size to 32k */
> if (ring_qsize > 32768)
> - return -E2BIG;
> + ring_qsize = 32768;
> +
>
> /* DMA direction is either DMA_FROM_DEVICE or DMA_BIDIRECTIONAL.
Don't introduce a blank line here. Checkpatch will complain if you
have to blank lines in a row. It won't complain about the patch but it
will complain if you apply the patch and then re-run checkpatch -f on
the file. (I didn't test this but it's wrong either way. :P).
regards,
dan carpenter
prev parent reply other threads:[~2023-09-05 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 6:04 [PATCH v1 net] page_pool: Cap queue size to 32k Ratheesh Kannoth
2023-08-14 7:54 ` Johannes Berg
2023-08-14 8:05 ` [EXT] " Ratheesh Kannoth
2023-08-14 8:45 ` Jesper Dangaard Brouer
2023-08-14 8:55 ` Ratheesh Kannoth
2023-09-05 9:57 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75bcd331-9a62-486f-a15f-6aebf4d1838b@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=Mark-MC.Lee@mediatek.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=aleksander.lobakin@intel.com \
--cc=alexanderduyck@fb.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrii@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ast@kernel.org \
--cc=broonie@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=gakula@marvell.com \
--cc=gerhard@engleder-embedded.com \
--cc=grygorii.strashko@ti.com \
--cc=haiyangz@microsoft.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=hkelam@marvell.com \
--cc=horatiu.vultur@microchip.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jaswinder.singh@linaro.org \
--cc=jdelvare@suse.com \
--cc=jgross@suse.com \
--cc=jiawenwu@trustnetic.com \
--cc=joabreu@synopsys.com \
--cc=john.fastabend@gmail.com \
--cc=john@phrozen.org \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=linyunsheng@huawei.com \
--cc=longli@microsoft.com \
--cc=lorenzo@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=martin.lau@linux.dev \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mengyuanlou@net-swift.com \
--cc=michael.chan@broadcom.com \
--cc=mw@semihalf.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rkannoth@marvell.com \
--cc=ryder.lee@mediatek.com \
--cc=saeedm@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=sbhatta@marvell.com \
--cc=sdf@google.com \
--cc=sean.wang@mediatek.com \
--cc=sgoutham@marvell.com \
--cc=shayne.chen@mediatek.com \
--cc=shenwei.wang@nxp.com \
--cc=shradhagupta@linux.microsoft.com \
--cc=simon.horman@corigine.com \
--cc=song@kernel.org \
--cc=sstabellini@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=wei.liu@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xiaoning.wang@nxp.com \
--cc=yang.lee@linux.alibaba.com \
--cc=yisen.zhuang@huawei.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox