From: David Ahern <dsahern@gmail.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>,
fw@strlen.de, pablo@netfilter.org
Cc: lschlesinger@drivenets.com, dsahern@kernel.org,
crosser@average.org, netfilter-devel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH nf] vrf: don't run conntrack on vrf with !dflt qdisc
Date: Sun, 28 Nov 2021 11:59:23 -0700 [thread overview]
Message-ID: <75f4ceed-b556-42ca-0a87-0bc0539139bb@gmail.com> (raw)
In-Reply-To: <20211126143612.11262-1-nicolas.dichtel@6wind.com>
On 11/26/21 7:36 AM, Nicolas Dichtel wrote:
> After the below patch, the conntrack attached to skb is set to "notrack" in
> the context of vrf device, for locally generated packets.
> But this is true only when the default qdisc is set to the vrf device. When
> changing the qdisc, notrack is not set anymore.
> In fact, there is a shortcut in the vrf driver, when the default qdisc is
> set, see commit dcdd43c41e60 ("net: vrf: performance improvements for
> IPv4") for more details.
>
> This patch ensures that the behavior is always the same, whatever the qdisc
> is.
>
> To demonstrate the difference, a new test is added in conntrack_vrf.sh.
>
> Fixes: 8c9c296adfae ("vrf: run conntrack only in context of lower/physdev for locally generated packets")
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
> drivers/net/vrf.c | 8 ++---
> .../selftests/netfilter/conntrack_vrf.sh | 30 ++++++++++++++++---
> 2 files changed, 30 insertions(+), 8 deletions(-)
>
Good catch. Thanks, Nicolas.
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2021-11-28 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 14:36 [PATCH nf] vrf: don't run conntrack on vrf with !dflt qdisc Nicolas Dichtel
2021-11-26 14:53 ` Florian Westphal
2021-11-28 18:59 ` David Ahern [this message]
2021-12-08 0:25 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75f4ceed-b556-42ca-0a87-0bc0539139bb@gmail.com \
--to=dsahern@gmail.com \
--cc=crosser@average.org \
--cc=dsahern@kernel.org \
--cc=fw@strlen.de \
--cc=lschlesinger@drivenets.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).