From: Jacob Keller <jacob.e.keller@intel.com>
To: netdev@vger.kernel.org
Cc: jiri@resnulli.us
Subject: Re: [PATCH] devlink: remove trigger command from devlink-region.rst
Date: Mon, 2 Mar 2020 14:22:09 -0800 [thread overview]
Message-ID: <76307bc8-0977-e52b-4ff8-ef0b61a6e7b6@intel.com> (raw)
In-Reply-To: <20200302222119.52140-1-jacob.e.keller@intel.com>
Heh, forgot to set subject properly, it should be [net].
Thanks,
Jake
On 3/2/2020 2:21 PM, Jacob Keller wrote:
> The devlink trigger command does not exist. While rewriting the
> documentation for devlink into the reStructuredText format,
> documentation for the trigger command was accidentally merged in. This
> occurred because the author was also working on a potential extension to
> devlink regions which included this trigger command, and accidentally
> squashed the documentation incorrectly.
>
> Further review eventually settled on using the previously unused "new"
> command instead of creating a new trigger command.
>
> Fix this by removing mention of the trigger command from the
> documentation.
>
> Fixes: 0b0f945f5458 ("devlink: add a file documenting devlink regions", 2020-01-10)
> Noticed-by: Jiri Pirko <jiri@resnulli.us>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> Documentation/networking/devlink/devlink-region.rst | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/networking/devlink/devlink-region.rst b/Documentation/networking/devlink/devlink-region.rst
> index 1a7683e7acb2..8b46e8591fe0 100644
> --- a/Documentation/networking/devlink/devlink-region.rst
> +++ b/Documentation/networking/devlink/devlink-region.rst
> @@ -40,9 +40,6 @@ example usage
> # Delete a snapshot using:
> $ devlink region del pci/0000:00:05.0/cr-space snapshot 1
>
> - # Trigger (request) a snapshot be taken:
> - $ devlink region trigger pci/0000:00:05.0/cr-space
> -
> # Dump a snapshot:
> $ devlink region dump pci/0000:00:05.0/fw-health snapshot 1
> 0000000000000000 0014 95dc 0014 9514 0035 1670 0034 db30
>
next prev parent reply other threads:[~2020-03-02 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 22:21 [PATCH] devlink: remove trigger command from devlink-region.rst Jacob Keller
2020-03-02 22:22 ` Jacob Keller [this message]
2020-03-03 13:31 ` Jiri Pirko
2020-03-04 1:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76307bc8-0977-e52b-4ff8-ef0b61a6e7b6@intel.com \
--to=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox