From: Maninder Singh <maninder1.s@samsung.com>
To: "Michael B?ch" <m@bues.ch>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
PANKAJ MISHRA <pankaj.m@samsung.com>
Subject: Re: [PATCH 1/1] ssb: remove unncessary out label
Date: Mon, 22 Jun 2015 03:47:39 +0000 (GMT) [thread overview]
Message-ID: <764435082.28361434944858940.JavaMail.weblogic@ep2mlwas07a> (raw)
Hi Michael,
>> pdev = bus->host_pci;
>> mutex_init(&bus->sprom_mutex);
>> - err = device_create_file(&pdev->dev, &dev_attr_ssb_sprom);
>> - if (err)
>> - goto out;
>> -
>> -out:
>> - return err;
>> + return device_create_file(&pdev->dev, &dev_attr_ssb_sprom);
>> }
>
>
>I don't really think this change adds any value, but if you insist on
>it you get my acked-by.
Yes You are right, But By this change code looks simpler.
Thats why i suggested the changes.
Thanks
Maninder
next reply other threads:[~2015-06-22 3:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 3:47 Maninder Singh [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-19 8:53 [PATCH 1/1] ssb: remove unncessary out label Maninder Singh
2015-06-19 15:13 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=764435082.28361434944858940.JavaMail.weblogic@ep2mlwas07a \
--to=maninder1.s@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m@bues.ch \
--cc=netdev@vger.kernel.org \
--cc=pankaj.m@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).