From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@linaro.org>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
Justin Chen <justin.chen@broadcom.com>
Cc: kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net] net: bcmasp: Fix error code in probe()
Date: Thu, 4 Jul 2024 18:02:17 +0200 [thread overview]
Message-ID: <7645fee3-7e92-455c-a136-061bebce1670@web.de> (raw)
In-Reply-To: <ZoWKBkHH9D1fqV4r@stanley.mountain>
> Return an error code if bcmasp_interface_create() fails. Don't return
> success.
Would you like to refer to the function name “bcmasp_probe” in the summary phrase?
Regards,
Markus
next prev parent reply other threads:[~2024-07-04 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 15:19 [PATCH net] net: bcmasp: Fix error code in probe() Dan Carpenter
2024-07-04 15:49 ` Michal Kubiak
2024-07-04 16:02 ` Markus Elfring [this message]
2024-07-05 22:49 ` Justin Chen
2024-07-06 0:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7645fee3-7e92-455c-a136-061bebce1670@web.de \
--to=markus.elfring@web.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=horms@kernel.org \
--cc=justin.chen@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).