From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Ansuel Smith <ansuelsmth@gmail.com>,
Tobias Waldekranz <tobias@waldekranz.com>,
DENG Qingfang <dqfext@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
UNGLinuxDriver@microchip.com, Jiri Pirko <jiri@resnulli.us>,
Ivan Vecera <ivecera@redhat.com>
Subject: Re: [PATCH v4 net-next 08/11] net: dsa: remove "ds" and "port" from struct dsa_switchdev_event_work
Date: Mon, 21 Feb 2022 19:50:56 -0800 [thread overview]
Message-ID: <76558b81-a5ea-ad23-07a5-d6f9ebfe9956@gmail.com> (raw)
In-Reply-To: <20220221212337.2034956-9-vladimir.oltean@nxp.com>
On 2/21/2022 1:23 PM, Vladimir Oltean wrote:
> By construction, the struct net_device *dev passed to
> dsa_slave_switchdev_event_work() via struct dsa_switchdev_event_work
> is always a DSA slave device.
>
> Therefore, it is redundant to pass struct dsa_switch and int port
> information in the deferred work structure. This can be retrieved at all
> times from the provided struct net_device via dsa_slave_to_port().
>
> For the same reason, we can drop the dsa_is_user_port() check in
> dsa_fdb_offload_notify().
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2022-02-22 3:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 21:23 [PATCH v4 net-next 00/11] FDB entries on DSA LAG interfaces Vladimir Oltean
2022-02-21 21:23 ` [PATCH v4 net-next 01/11] net: dsa: rename references to "lag" as "lag_dev" Vladimir Oltean
2022-02-22 3:24 ` Florian Fainelli
2022-02-21 21:23 ` [PATCH v4 net-next 02/11] net: dsa: mv88e6xxx: " Vladimir Oltean
2022-02-22 3:25 ` Florian Fainelli
2022-02-21 21:23 ` [PATCH v4 net-next 03/11] net: dsa: qca8k: " Vladimir Oltean
2022-02-22 3:26 ` Florian Fainelli
2022-02-21 21:23 ` [PATCH v4 net-next 04/11] net: dsa: make LAG IDs one-based Vladimir Oltean
2022-02-22 3:43 ` Florian Fainelli
2022-02-21 21:23 ` [PATCH v4 net-next 05/11] net: dsa: mv88e6xxx: use dsa_switch_for_each_port in mv88e6xxx_lag_sync_masks Vladimir Oltean
2022-02-22 3:27 ` Florian Fainelli
2022-02-21 21:23 ` [PATCH v4 net-next 06/11] net: dsa: create a dsa_lag structure Vladimir Oltean
2022-02-22 3:47 ` Florian Fainelli
2022-02-21 21:23 ` [PATCH v4 net-next 07/11] net: switchdev: remove lag_mod_cb from switchdev_handle_fdb_event_to_device Vladimir Oltean
2022-02-22 3:50 ` Florian Fainelli
2022-02-21 21:23 ` [PATCH v4 net-next 08/11] net: dsa: remove "ds" and "port" from struct dsa_switchdev_event_work Vladimir Oltean
2022-02-22 3:50 ` Florian Fainelli [this message]
2022-02-21 21:23 ` [PATCH v4 net-next 09/11] net: dsa: call SWITCHDEV_FDB_OFFLOADED for the orig_dev Vladimir Oltean
2022-02-22 3:51 ` Florian Fainelli
2022-02-21 21:23 ` [PATCH v4 net-next 10/11] net: dsa: support FDB events on offloaded LAG interfaces Vladimir Oltean
2022-02-21 21:23 ` [PATCH v4 net-next 11/11] net: dsa: felix: support FDB entries " Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76558b81-a5ea-ad23-07a5-d6f9ebfe9956@gmail.com \
--to=f.fainelli@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).