netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] tc: Add support for ce_threshold_value/mask in fq_codel
Date: Fri, 3 Dec 2021 10:20:04 -0700	[thread overview]
Message-ID: <765eb3d8-7dfa-2b28-e276-fac88453bc72@gmail.com> (raw)
In-Reply-To: <20211123201327.86219-1-toke@redhat.com>

On 11/23/21 1:13 PM, Toke Høiland-Jørgensen wrote:
> Commit dfcb63ce1de6 ("fq_codel: generalise ce_threshold marking for subset
> of traffic") added support in fq_codel for setting a value and mask that
> will be applied to the diffserv/ECN byte to turn on the ce_threshold
> feature for a subset of traffic.
> 
> This adds support to tc for setting these values. The parameter is
> called ce_threshold_selector and takes a value followed by a
> slash-separated mask. Some examples:
> 
>  # apply ce_threshold to ECT(1) traffic
>  tc qdisc replace dev eth0 root fq_codel ce_threshold 1ms ce_threshold_selector 0x1/0x3
> 
>  # apply ce_threshold to ECN-capable traffic marked as diffserv AF22
>  tc qdisc replace dev eth0 root fq_codel ce_threshold 1ms ce_threshold_selector 0x50/0xfc
> 
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
> ---
>  tc/q_fq_codel.c | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)

please re-send with an update to

  reply	other threads:[~2021-12-03 17:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 20:13 [PATCH iproute2-next] tc: Add support for ce_threshold_value/mask in fq_codel Toke Høiland-Jørgensen
2021-12-03 17:20 ` David Ahern [this message]
2021-12-05 22:03   ` Toke Høiland-Jørgensen
2021-12-07 16:14     ` David Ahern
2021-12-07 17:46       ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=765eb3d8-7dfa-2b28-e276-fac88453bc72@gmail.com \
    --to=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).