From: "\"Oleg A. Arkhangelsky\"" <sysoleg@yandex.ru>
To: netdev@vger.kernel.org
Subject: Re: [RFC 4/4] bond: add new multiqueue hash policy
Date: Fri, 19 Feb 2010 20:54:17 +0300 [thread overview]
Message-ID: <76601266602057@webmail50.yandex.ru> (raw)
Hello Stephen,
> This hash policy just uses existing transmit hash used for
> mulitiqueue.
> Signed-off-by: Stephen Hemminger
> +/*
> + * Hash for the output device based on multiqueue transmit hash policy
> + */
> +static u16 bond_xmit_hash_policy_mq(const struct sk_buff *skb)
> +{
> + return skb_tx_hash(skb->dev, skb);
> +}
I think that it would be better to use something like this here:
return skb_rx_queue_recorded(skb) ? skb_get_rx_queue(skb) : 0;
Bonding is currently non-multiqueue aware and skb_tx_hash() will return zero
everytime.
--
wbr, Oleg.
next reply other threads:[~2010-02-19 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 17:54 "Oleg A. Arkhangelsky" [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-04 17:11 [RFC 0/4] bond hashing revised Stephen Hemminger
2010-02-04 17:11 ` [RFC 4/4] bond: add new multiqueue hash policy Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76601266602057@webmail50.yandex.ru \
--to=sysoleg@yandex.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).