From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH 2/5] VSOCK: support fill data to mergeable rx buffer in host Date: Wed, 7 Nov 2018 21:32:42 +0800 Message-ID: <76732898-8e4f-910a-aac5-ea4b635a1c15@redhat.com> References: <5BDFF537.3050806@huawei.com> <485c2c5d-d73e-e679-9549-aad3de02f0ab@redhat.com> <5BE134EF.1070009@huawei.com> <8963dba5-c2fb-69d0-4adb-72d751a9dedf@redhat.com> <5BE2903C.50608@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: netdev@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org To: jiangyiwen , stefanha@redhat.com, stefanha@gmail.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:28593 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726411AbeKGXDQ (ORCPT ); Wed, 7 Nov 2018 18:03:16 -0500 In-Reply-To: <5BE2903C.50608@huawei.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2018/11/7 下午3:11, jiangyiwen wrote: > On 2018/11/7 14:18, Jason Wang wrote: >> On 2018/11/6 下午2:30, jiangyiwen wrote: >>>> Seems duplicated with the one used by vhost-net. >>>> >>>> In packed virtqueue implementation, I plan to move this to vhost.c. >>>> >>> Yes, this code is full copied from vhost-net, if it can be packed into >>> vhost.c, it would be great. >>> >> If you try to reuse vhost-net, you don't even need to care about this:) >> >> Thanks >> >> >> . >> > Hi Jason, > > Thank your advice, I will consider your idea. But I don't know > what's stefan's suggestion? It seems that he doesn't care much > about this community.:( I think not. He is probably busy these days. > > I still hope this community can have some vitality. > Let's wait for few more days for the possible comments from Stefan or Michael. But I do prefer to unify the virtio networking datapath which will be easier to be extended and maintained. Thanks