From: Arnd Bergmann <arnd@arndb.de>
To: huangdaode <huangdaode@hisilicon.com>
Cc: Joe Perches <joe@perches.com>,
davem@davemloft.net, liguozhu@hisilicon.com,
Yisen.Zhuang@huawei.com, netdev@vger.kernel.org,
linuxarm@huawei.com, salil.mehta@huawei.com,
kenneth-lee-2012@foxmail.com, xuwei5@hisilicon.com,
lisheng011@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro
Date: Mon, 12 Oct 2015 13:53:42 +0200 [thread overview]
Message-ID: <7677925.qV8yFrBeTx@wuerfel> (raw)
In-Reply-To: <561B2B30.1020400@hisilicon.com>
On Monday 12 October 2015 11:38:24 huangdaode wrote:
> On 2015/10/12 11:24, Joe Perches wrote:
> > Hello Huang.
> >
> > On Mon, 2015-10-12 at 11:23 +0800, huangdaode wrote:
> >> This patch changes the code style to make the code more simple.
> >> also removes the once used HNADEL_TX_MSG macro, according to the
> > HANDEL_TX_MSG typo
> >
> >> review comments from Joe Perches.
> >>
> >> Signed-off-by: huangdaode <huangdaode@hisilicon.com>
> >> Reviewed-by: Joe Perches <joe@perches.com>
> > I didn't review this.
> > '
> Hi Joe
> please refer to http://lists.openwall.net/netdev/2015/10/11/61
You should only add the "Reviewed-by" tag to a commit message
if the person you are adding replied with this explicitly.
Don't add it just because someone gave feedback.
Arnd
next prev parent reply other threads:[~2015-10-12 11:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 3:23 [PATCH net-next v2 0/2] hisilicon net: fix some bugs in HNS drivers huangdaode
2015-10-12 3:23 ` [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro huangdaode
2015-10-12 3:24 ` Joe Perches
2015-10-12 3:38 ` huangdaode
2015-10-12 11:53 ` Arnd Bergmann [this message]
2015-10-12 11:59 ` Arnd Bergmann
2015-10-12 16:12 ` Joe Perches
[not found] ` <561CAD6D.2060105@hisilicon.com>
2015-10-13 13:27 ` Fwd: " Kenneth Lee
2015-10-13 14:18 ` Arnd Bergmann
2015-10-15 15:32 ` Kenneth Lee
2015-10-12 3:23 ` [PATCH net-next v2 2/2] hisilicon net: fix a bug on Hisilicon Network Subsystem huangdaode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7677925.qV8yFrBeTx@wuerfel \
--to=arnd@arndb.de \
--cc=Yisen.Zhuang@huawei.com \
--cc=davem@davemloft.net \
--cc=huangdaode@hisilicon.com \
--cc=joe@perches.com \
--cc=kenneth-lee-2012@foxmail.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lisheng011@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).