From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next 11/18] ipv6: Add explicit flush indication to routes Date: Sun, 7 Jan 2018 10:03:29 -0700 Message-ID: <769e0521-3a12-4e52-20ea-8dc3dc5aa60b@gmail.com> References: <20180107104518.31693-1-idosch@mellanox.com> <20180107104518.31693-12-idosch@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, roopa@cumulusnetworks.com, nicolas.dichtel@6wind.com, weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org, mlxsw@mellanox.com To: Ido Schimmel , netdev@vger.kernel.org Return-path: Received: from mail-pg0-f43.google.com ([74.125.83.43]:36452 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754121AbeAGRDb (ORCPT ); Sun, 7 Jan 2018 12:03:31 -0500 Received: by mail-pg0-f43.google.com with SMTP id j2so2767997pgv.3 for ; Sun, 07 Jan 2018 09:03:31 -0800 (PST) In-Reply-To: <20180107104518.31693-12-idosch@mellanox.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/7/18 3:45 AM, Ido Schimmel wrote: > When routes that are a part of a multipath route are evaluated by > fib6_ifdown() in response to NETDEV_DOWN and NETDEV_UNREGISTER events > the state of their sibling routes is not considered. > > This will change in subsequent patches in order to align IPv6 with > IPv4's behavior. For example, when the last sibling in a multipath route > becomes dead, the entire multipath route needs to be removed. > > To prevent the tree walker from re-evaluating all the sibling routes > each time, we can simply evaluate them once - when the first sibling is > traversed. > > If we determine the entire multipath route needs to be removed, then the > 'should_flush' bit is set in all the siblings, which will cause the > walker to flush them when it traverses them. > > Signed-off-by: Ido Schimmel > --- > include/net/ip6_fib.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Acked-by: David Ahern