From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1666EC43613 for ; Sun, 23 Jun 2019 16:26:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5041206BA for ; Sun, 23 Jun 2019 16:26:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726648AbfFWQ0a (ORCPT ); Sun, 23 Jun 2019 12:26:30 -0400 Received: from smtprelay0223.hostedemail.com ([216.40.44.223]:59793 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726612AbfFWQ0a (ORCPT ); Sun, 23 Jun 2019 12:26:30 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 1B447100E86C0; Sun, 23 Jun 2019 16:26:29 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: wire66_1b61c99b2863e X-Filterd-Recvd-Size: 2367 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf03.hostedemail.com (Postfix) with ESMTPA; Sun, 23 Jun 2019 16:26:28 +0000 (UTC) Message-ID: <76a3c9ed832dd1183a5c38bf5e581a4b080d06c0.camel@perches.com> Subject: Re: [PATCH] sis900: increment revision number From: Joe Perches To: David Miller , venza@brownhat.org Cc: sergej.benilov@googlemail.com, netdev@vger.kernel.org Date: Sun, 23 Jun 2019 09:26:26 -0700 In-Reply-To: <20190623.083724.172652862205625872.davem@davemloft.net> References: <20190623074707.6348-1-sergej.benilov@googlemail.com> <8eb161f4757cc55d7138bf5d30014e8fb8e38a0d.camel@perches.com> <7038d64e-0d3c-6b13-04fd-b614efbf5162@brownhat.org> <20190623.083724.172652862205625872.davem@davemloft.net> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 2019-06-23 at 08:37 -0700, David Miller wrote: > From: Daniele Venzano > Date: Sun, 23 Jun 2019 11:13:28 +0200 > > > Hello, > > > > I think it is good to know just by looking at the sources that the > > driver is still kept up-to-date, so I am in favor of this patch. > > I absolutely, strongly, disagree. > > These are pointless. Perhaps (most)? all the .get_drvinfo function calls where the driver version is returned should use the default release. This is similar to net/wireless/ethtool.c Maybe: --- net/core/ethtool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/core/ethtool.c b/net/core/ethtool.c index 4d1011b2e24f..644a2043714c 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include #include @@ -806,6 +807,8 @@ static noinline_for_stack int ethtool_get_drvinfo(struct net_device *dev, devlink_compat_running_version(dev, info.fw_version, sizeof(info.fw_version)); + strlcpy(info.version, init_utsname()->release, sizeof(info.version)); + if (copy_to_user(useraddr, &info, sizeof(info))) return -EFAULT; return 0;