From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, jiri@resnulli.us, netdev@vger.kernel.org,
kernel-team@fb.com, jacob.e.keller@intel.com
Subject: Re: [PATCH iproute2-next v3] devlink: support kernel-side snapshot id allocation
Date: Tue, 5 May 2020 10:59:28 -0600 [thread overview]
Message-ID: <76a99d9c-3574-1c8d-07cb-1f16e1bf9cca@gmail.com> (raw)
In-Reply-To: <20200505092009.1cfe01c0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 5/5/20 10:20 AM, Jakub Kicinski wrote:
> On Tue, 5 May 2020 10:14:24 -0600 David Ahern wrote:
>> On 4/30/20 11:57 AM, Jakub Kicinski wrote:
>>> Make ID argument optional and read the snapshot info
>>> that kernel sends us.
>>>
>>> $ devlink region new netdevsim/netdevsim1/dummy
>>> netdevsim/netdevsim1/dummy: snapshot 0
>>> $ devlink -jp region new netdevsim/netdevsim1/dummy
>>> {
>>> "regions": {
>>> "netdevsim/netdevsim1/dummy": {
>>> "snapshot": [ 1 ]
>>> }
>>> }
>>> }
>>> $ devlink region show netdevsim/netdevsim1/dummy
>>> netdevsim/netdevsim1/dummy: size 32768 snapshot [0 1]
>>>
>>> v3: back to v1..
>>>
>>> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>>> ---
>>> devlink/devlink.c | 26 +++++++++++++++++++++++---
>>> 1 file changed, 23 insertions(+), 3 deletions(-)
>>
>> this does not apply to current iproute2-next
>
> Hm. This was on top of Jake's patch, but Stephen took that one into
> iproute2, since the kernel feature is in 5.7 already. What is the
> protocol here? Can you merge iproute2 into iproute2-next? :S
>
merged and pushed. can you resend? I deleted it after it failed to apply
and now has vanished.
next prev parent reply other threads:[~2020-05-05 16:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 17:57 [PATCH net-next v3 0/3] devlink: kernel region snapshot id allocation Jakub Kicinski
2020-04-30 17:57 ` [PATCH net-next v3 1/3] devlink: factor out building a snapshot notification Jakub Kicinski
2020-05-01 8:51 ` Jiri Pirko
2020-05-01 21:27 ` Jacob Keller
2020-04-30 17:57 ` [PATCH net-next v3 2/3] devlink: let kernel allocate region snapshot id Jakub Kicinski
2020-05-01 8:59 ` Jiri Pirko
2020-05-01 21:32 ` Jacob Keller
2020-04-30 17:57 ` [PATCH net-next v3 3/3] docs: devlink: clarify the scope of " Jakub Kicinski
2020-05-01 8:59 ` Jiri Pirko
2020-05-01 21:34 ` Jacob Keller
2020-04-30 17:57 ` [PATCH iproute2-next v3] devlink: support kernel-side snapshot id allocation Jakub Kicinski
2020-05-02 5:58 ` Jiri Pirko
2020-05-05 16:14 ` David Ahern
2020-05-05 16:20 ` Jakub Kicinski
2020-05-05 16:59 ` David Ahern [this message]
2020-05-05 17:04 ` [PATCH iproute2-next RESEND] " Jakub Kicinski
2020-05-05 17:11 ` David Ahern
2020-05-05 17:05 ` [PATCH iproute2-next v3] " Jakub Kicinski
2020-05-05 17:06 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76a99d9c-3574-1c8d-07cb-1f16e1bf9cca@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).