From: Paolo Abeni <pabeni@redhat.com>
To: Hangbin Liu <liuhangbin@gmail.com>, netdev@vger.kernel.org
Cc: David Ahern <dsa@cumulusnetworks.com>,
Jianguo Wu <wujianguo@chinatelecom.cn>,
Daniel Borkmann <daniel@iogearbox.net>,
Mahesh Bandewar <maheshb@google.com>
Subject: Re: [PATCH net] ipvlan: fix bound dev checking for IPv6 l3s mode
Date: Thu, 08 Jun 2023 10:46:47 +0200 [thread overview]
Message-ID: <76ae9edbc10e8715797a0c1d9ef588fd72fe08f0.camel@redhat.com> (raw)
In-Reply-To: <20230607084530.2739069-1-liuhangbin@gmail.com>
On Wed, 2023-06-07 at 16:45 +0800, Hangbin Liu wrote:
> The commit 59a0b022aa24 ("ipvlan: Make skb->skb_iif track skb->dev for l3s
> mode") fixed ipvlan bonded dev checking by updating skb skb_iif. This fix
> works for IPv4, as in raw_v4_input() the dif is from inet_iif(skb), which
> is skb->skb_iif when there is no route.
>
> But for IPv6, the fix is not enough, because in ipv6_raw_deliver() ->
> raw_v6_match(), the dif is inet6_iif(skb), which is returns IP6CB(skb)->iif
> instead of skb->skb_iif if it's not a l3_slave. To fix the IPv6 part
> issue. Let's set IP6SKB_L3SLAVE flag for ipvlan l3s input packets.
>
> Fixes: c675e06a98a4 ("ipvlan: decouple l3s mode dependencies from other modes")
> Link: https://bugzilla.redhat.com/show_bug.cgi?id=2196710
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> I'm not 100% sure if we can use IP6SKB_L3SLAVE flag for ipvlan.
I'm unsure either ;) Especially for a -net patch, as the implication on
later stack processing are fairly not trivial to me.
What about instead just setting IP6CB(skb)->iif for ipv6 packets?
Side notes we could possibly use nf hooks for ipv4 and ipv6
Thanks!
Paolo
prev parent reply other threads:[~2023-06-08 8:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 8:45 [PATCH net] ipvlan: fix bound dev checking for IPv6 l3s mode Hangbin Liu
2023-06-08 8:46 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76ae9edbc10e8715797a0c1d9ef588fd72fe08f0.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=daniel@iogearbox.net \
--cc=dsa@cumulusnetworks.com \
--cc=liuhangbin@gmail.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=wujianguo@chinatelecom.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).