From: Matthieu Baerts <matttbe@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
pabeni@redhat.com, sdf@fomichev.me,
linux-kselftest@vger.kernel.org,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net] selftests/net: packetdrill: increase timing tolerance in debug mode
Date: Thu, 26 Sep 2024 11:12:25 +0200 [thread overview]
Message-ID: <76d0de38-aff5-41e9-8085-afeb97b4d4f4@kernel.org> (raw)
In-Reply-To: <0849977a-e772-4778-9130-c8ac0539bbdc@kernel.org>
Hi Willem,
On 20/09/2024 00:03, Matthieu Baerts wrote:
> On 19/09/2024 14:43, Willem de Bruijn wrote:
>> From: Willem de Bruijn <willemb@google.com>
(...)
>> We have been doing this for debug builds outside ksft too.
>>
>> Previous setting was 10000. A manual 50 runs in virtme-ng showed two
>> failures that needed 12000. To be on the safe side, Increase to 14000.
>
> So far (in 3 runs), it looks like 14000 is enough. But I guess it is
> still a bit too early to conclude that.
>
> https://netdev.bots.linux.dev/contest.html?executor=vmksft-packetdrill-dbg
>
> (Your patch has been introduced in the net-next-2024-09-19--15-00 branch.)
One week after the introduction of this patch and >50 builds, it looks
like the results are good, only one issue related to timing issues:
https://netdev-3.bots.linux.dev/vmksft-packetdrill-dbg/results/782181/1-tcp-slow-start-slow-start-after-win-update-pkt/stdout
And it passed after a retry.
https://netdev.bots.linux.dev/flakes.html?min-flip=0&tn-needle=packetdrill
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-09-26 9:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 12:43 [PATCH net] selftests/net: packetdrill: increase timing tolerance in debug mode Willem de Bruijn
2024-09-19 13:55 ` Simon Horman
2024-09-19 21:04 ` Stanislav Fomichev
2024-09-26 9:03 ` Paolo Abeni
2024-09-19 22:03 ` Matthieu Baerts
2024-09-26 9:12 ` Matthieu Baerts [this message]
2024-09-26 9:28 ` Willem de Bruijn
2024-09-26 9:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76d0de38-aff5-41e9-8085-afeb97b4d4f4@kernel.org \
--to=matttbe@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).