From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: Latest net-next kernel 4.19.0+ Date: Tue, 30 Oct 2018 07:16:18 -0700 Message-ID: <76dfbbda-d7f1-b13a-5921-c12c3b0f8e3e@gmail.com> References: <59d5657c-ea0a-7b64-d5ff-5b55eb4fcccf@itcare.pl> <1e954663-ed05-4f33-4384-db880844f9d1@gmail.com> <68f25a28-b79e-d3ae-6eef-50c354ad63ae@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Cong Wang , Linux Kernel Network Developers To: =?UTF-8?Q?Pawe=c5=82_Staszewski?= , Dimitris Michailidis Return-path: Received: from mail-pl1-f176.google.com ([209.85.214.176]:44182 "EHLO mail-pl1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728033AbeJ3XKA (ORCPT ); Tue, 30 Oct 2018 19:10:00 -0400 Received: by mail-pl1-f176.google.com with SMTP id s5-v6so3974889plq.11 for ; Tue, 30 Oct 2018 07:16:21 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/30/2018 01:09 AM, Paweł Staszewski wrote: > > > W dniu 30.10.2018 o 08:29, Eric Dumazet pisze: >> >> On 10/29/2018 11:09 PM, Dimitris Michailidis wrote: >> >>> Indeed this is a bug. I would expect it to produce frequent errors >>> though as many odd-length >>> packets would trigger it. Do you have RXFCS? Regardless, how >>> frequently do you see the problem? >>> >> Old kernels (before 88078d98d1bb) were simply resetting ip_summed to CHECKSUM_NONE >> >> And before your fix (commit d55bef5059dd057bd), mlx5 bug was canceling the bug you fixed. >> >> So we now need to also fix mlx5. >> >> And of course use skb_header_pointer() in mlx5e_get_fcs() as I mentioned earlier, >> plus __get_unaligned_cpu32() as you hinted. >> >> >> >> > > No RXFCS > > And this trace is rly frequently like once per 3/4 seconds > like below: > [28965.776864] vlan1490: hw csum failure Might be vlan related. Can you first check this : diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c index 94224c22ecc310a87b6715051e335446f29bec03..6f4bfebf0d9a3ae7567062abb3ea6532b3aaf3d6 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c @@ -789,13 +789,8 @@ static inline void mlx5e_handle_csum(struct net_device *netdev, skb->ip_summed = CHECKSUM_COMPLETE; skb->csum = csum_unfold((__force __sum16)cqe->check_sum); if (network_depth > ETH_HLEN) - /* CQE csum is calculated from the IP header and does - * not cover VLAN headers (if present). This will add - * the checksum manually. - */ - skb->csum = csum_partial(skb->data + ETH_HLEN, - network_depth - ETH_HLEN, - skb->csum); + /* Temporary debugging */ + skb->ip_summed = CHECKSUM_NONE; if (unlikely(netdev->features & NETIF_F_RXFCS)) skb->csum = csum_add(skb->csum, (__force __wsum)mlx5e_get_fcs(skb));