From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: void0red <void0red@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
simon.horman@corigine.com
Subject: Re: [PATCH v3] nfc: fdp: add null check of devm_kmalloc_array in fdp_nci_i2c_read_device_properties
Date: Mon, 27 Feb 2023 10:44:31 +0100 [thread overview]
Message-ID: <76e2daf5-0f04-ce02-7c16-1eff3576b3de@linaro.org> (raw)
In-Reply-To: <20230227093037.907654-1-void0red@gmail.com>
On 27/02/2023 10:30, void0red wrote:
> From: Kang Chen <void0red@gmail.com>
>
> devm_kmalloc_array may fails, *fw_vsc_cfg might be null and cause
> out-of-bounds write in device_property_read_u8_array later.
>
> Fixes: a06347c04c13 ("NFC: Add Intel Fields Peak NFC solution driver")
> Signed-off-by: Kang Chen <void0red@gmail.com>
> ---
> v3 -> v2: remove useless prompt and blank lines between tags.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-27 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 9:59 [PATCH] nfc: fdp: add null check of devm_kmalloc_array in fdp_nci_i2c_read_device_properties Kang Chen
2023-02-26 15:33 ` Simon Horman
2023-02-27 1:26 ` Kang Chen
2023-02-27 1:41 ` [PATCH v2] " Kang Chen
2023-02-27 8:02 ` Krzysztof Kozlowski
2023-02-27 9:30 ` [PATCH v3] " void0red
2023-02-27 9:44 ` Krzysztof Kozlowski [this message]
2023-02-27 12:12 ` Simon Horman
2023-02-28 11:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76e2daf5-0f04-ce02-7c16-1eff3576b3de@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@corigine.com \
--cc=void0red@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).