From: Johannes Berg <johannes@sipsolutions.net>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: "David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Kalle Valo" <kvalo@kernel.org>, "Felix Fietkau" <nbd@nbd.name>,
"Simon Wunderlich" <sw@simonwunderlich.de>,
"Sven Eckelmann" <sven@narfation.org>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Linus Lüssing" <ll@simonwunderlich.de>
Subject: Re: [PATCH] mac80211: Fix wrong channel bandwidths reported for aggregates
Date: Thu, 21 Jul 2022 16:43:46 +0200 [thread overview]
Message-ID: <76e53d3ef853fc963e7243194d7538d34a224a3a.camel@sipsolutions.net> (raw)
In-Reply-To: <20220718222804.21708-1-linus.luessing@c0d3.blue>
On Tue, 2022-07-19 at 00:28 +0200, Linus Lüssing wrote:
>
> Therefore fixing this within mac80211: For an aggergated AMPDU only
> update the RX "last_rate" variable from the last sub-frame of an
> aggregate. In theory, without hardware bugs, rate/bandwidth info
> should be the same for all sub-frames of an aggregate anyway.
>
What if other drivers do it only on the first? :)
I'd be more inclined to squeeze in a "RATE_INVALID" flag or so somewhere
there in the rx status, and make it depend on that.
johannes
prev parent reply other threads:[~2022-07-21 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 22:28 [PATCH] mac80211: Fix wrong channel bandwidths reported for aggregates Linus Lüssing
2022-07-19 15:03 ` Adrian Chadd
2022-07-19 15:36 ` Linus Lüssing
2022-07-20 10:57 ` Toke Høiland-Jørgensen
2022-07-21 14:43 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76e53d3ef853fc963e7243194d7538d34a224a3a.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linus.luessing@c0d3.blue \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ll@simonwunderlich.de \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox