* [PATCH net-next 0/3] r8169: disable detection of further chip versions that didn't make it to the mass market
@ 2021-11-15 20:50 Heiner Kallweit
2021-11-15 20:51 ` [PATCH net-next 1/3] r8169: disable detection of chip versions 49 and 50 Heiner Kallweit
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: Heiner Kallweit @ 2021-11-15 20:50 UTC (permalink / raw)
To: Jakub Kicinski, David Miller, Realtek linux nic maintainers
Cc: netdev@vger.kernel.org
There's no sign of life from further chip versions. Seems they didn't
make it to the mass market. Let's disable detection and if nobody
complains remove support a few kernel versions later.
Heiner Kallweit (3):
r8169: disable detection of chip versions 49 and 50
r8169: disable detection of chip version 45
r8169: disable detection of chip version 41
drivers/net/ethernet/realtek/r8169_main.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
--
2.33.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH net-next 1/3] r8169: disable detection of chip versions 49 and 50
2021-11-15 20:50 [PATCH net-next 0/3] r8169: disable detection of further chip versions that didn't make it to the mass market Heiner Kallweit
@ 2021-11-15 20:51 ` Heiner Kallweit
2021-11-15 20:51 ` [PATCH net-next 2/3] r8169: disable detection of chip version 45 Heiner Kallweit
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Heiner Kallweit @ 2021-11-15 20:51 UTC (permalink / raw)
To: Jakub Kicinski, David Miller, Realtek linux nic maintainers
Cc: netdev@vger.kernel.org
It seems these chip versions never made it to the wild. Therefore
disable detection and if nobody complains remove support completely
later.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 6e46397f0..3033f1222 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -1978,8 +1978,11 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii)
/* 8168EP family. */
{ 0x7cf, 0x502, RTL_GIGA_MAC_VER_51 },
- { 0x7cf, 0x501, RTL_GIGA_MAC_VER_50 },
- { 0x7cf, 0x500, RTL_GIGA_MAC_VER_49 },
+ /* It seems this chip version never made it to
+ * the wild. Let's disable detection.
+ * { 0x7cf, 0x501, RTL_GIGA_MAC_VER_50 },
+ * { 0x7cf, 0x500, RTL_GIGA_MAC_VER_49 },
+ */
/* 8168H family. */
{ 0x7cf, 0x541, RTL_GIGA_MAC_VER_46 },
--
2.33.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH net-next 2/3] r8169: disable detection of chip version 45
2021-11-15 20:50 [PATCH net-next 0/3] r8169: disable detection of further chip versions that didn't make it to the mass market Heiner Kallweit
2021-11-15 20:51 ` [PATCH net-next 1/3] r8169: disable detection of chip versions 49 and 50 Heiner Kallweit
@ 2021-11-15 20:51 ` Heiner Kallweit
2021-11-15 20:52 ` [PATCH net-next 3/3] r8169: disable detection of chip version 41 Heiner Kallweit
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Heiner Kallweit @ 2021-11-15 20:51 UTC (permalink / raw)
To: Jakub Kicinski, David Miller, Realtek linux nic maintainers
Cc: netdev@vger.kernel.org
It seems this chip version never made it to the wild. Therefore
disable detection and if nobody complains remove support completely
later.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 3033f1222..c4dda39e4 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -1986,7 +1986,10 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii)
/* 8168H family. */
{ 0x7cf, 0x541, RTL_GIGA_MAC_VER_46 },
- { 0x7cf, 0x540, RTL_GIGA_MAC_VER_45 },
+ /* It seems this chip version never made it to
+ * the wild. Let's disable detection.
+ * { 0x7cf, 0x540, RTL_GIGA_MAC_VER_45 },
+ */
/* 8168G family. */
{ 0x7cf, 0x5c8, RTL_GIGA_MAC_VER_44 },
--
2.33.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH net-next 3/3] r8169: disable detection of chip version 41
2021-11-15 20:50 [PATCH net-next 0/3] r8169: disable detection of further chip versions that didn't make it to the mass market Heiner Kallweit
2021-11-15 20:51 ` [PATCH net-next 1/3] r8169: disable detection of chip versions 49 and 50 Heiner Kallweit
2021-11-15 20:51 ` [PATCH net-next 2/3] r8169: disable detection of chip version 45 Heiner Kallweit
@ 2021-11-15 20:52 ` Heiner Kallweit
2021-11-17 3:20 ` [PATCH net-next 0/3] r8169: disable detection of further chip versions that didn't make it to the mass market patchwork-bot+netdevbpf
2021-11-24 20:44 ` [PATCH net-next] r8169: disable detection of chip version 60 Heiner Kallweit
4 siblings, 0 replies; 7+ messages in thread
From: Heiner Kallweit @ 2021-11-15 20:52 UTC (permalink / raw)
To: Jakub Kicinski, David Miller, Realtek linux nic maintainers
Cc: netdev@vger.kernel.org
It seems this chip version never made it to the wild. Therefore
disable detection and if nobody complains remove support completely
later.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index c4dda39e4..303b61a2b 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -1994,7 +1994,10 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii)
/* 8168G family. */
{ 0x7cf, 0x5c8, RTL_GIGA_MAC_VER_44 },
{ 0x7cf, 0x509, RTL_GIGA_MAC_VER_42 },
- { 0x7cf, 0x4c1, RTL_GIGA_MAC_VER_41 },
+ /* It seems this chip version never made it to
+ * the wild. Let's disable detection.
+ * { 0x7cf, 0x4c1, RTL_GIGA_MAC_VER_41 },
+ */
{ 0x7cf, 0x4c0, RTL_GIGA_MAC_VER_40 },
/* 8168F family. */
--
2.33.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH net-next 0/3] r8169: disable detection of further chip versions that didn't make it to the mass market
2021-11-15 20:50 [PATCH net-next 0/3] r8169: disable detection of further chip versions that didn't make it to the mass market Heiner Kallweit
` (2 preceding siblings ...)
2021-11-15 20:52 ` [PATCH net-next 3/3] r8169: disable detection of chip version 41 Heiner Kallweit
@ 2021-11-17 3:20 ` patchwork-bot+netdevbpf
2021-11-24 20:44 ` [PATCH net-next] r8169: disable detection of chip version 60 Heiner Kallweit
4 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-17 3:20 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: kuba, davem, nic_swsd, netdev
Hello:
This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 15 Nov 2021 21:50:11 +0100 you wrote:
> There's no sign of life from further chip versions. Seems they didn't
> make it to the mass market. Let's disable detection and if nobody
> complains remove support a few kernel versions later.
>
> Heiner Kallweit (3):
> r8169: disable detection of chip versions 49 and 50
> r8169: disable detection of chip version 45
> r8169: disable detection of chip version 41
>
> [...]
Here is the summary with links:
- [net-next,1/3] r8169: disable detection of chip versions 49 and 50
https://git.kernel.org/netdev/net-next/c/2d6600c754f8
- [net-next,2/3] r8169: disable detection of chip version 45
https://git.kernel.org/netdev/net-next/c/6c8a5cf97c3f
- [net-next,3/3] r8169: disable detection of chip version 41
https://git.kernel.org/netdev/net-next/c/364ef1f37857
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH net-next] r8169: disable detection of chip version 60
2021-11-15 20:50 [PATCH net-next 0/3] r8169: disable detection of further chip versions that didn't make it to the mass market Heiner Kallweit
` (3 preceding siblings ...)
2021-11-17 3:20 ` [PATCH net-next 0/3] r8169: disable detection of further chip versions that didn't make it to the mass market patchwork-bot+netdevbpf
@ 2021-11-24 20:44 ` Heiner Kallweit
2021-11-26 3:20 ` patchwork-bot+netdevbpf
4 siblings, 1 reply; 7+ messages in thread
From: Heiner Kallweit @ 2021-11-24 20:44 UTC (permalink / raw)
To: Jakub Kicinski, David Miller, Realtek linux nic maintainers
Cc: netdev@vger.kernel.org
It seems only XID 609 made it to the mass market. Therefore let's
disable detection of the other RTL8125a XID's. If nobody complains
we can remove support for RTL_GIGA_MAC_VER_60 later.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index e9b560051..76a029860 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -1969,8 +1969,11 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii)
{ 0x7cf, 0x641, RTL_GIGA_MAC_VER_63 },
/* 8125A family. */
- { 0x7cf, 0x608, RTL_GIGA_MAC_VER_60 },
- { 0x7c8, 0x608, RTL_GIGA_MAC_VER_61 },
+ { 0x7cf, 0x609, RTL_GIGA_MAC_VER_61 },
+ /* It seems only XID 609 made it to the mass market.
+ * { 0x7cf, 0x608, RTL_GIGA_MAC_VER_60 },
+ * { 0x7c8, 0x608, RTL_GIGA_MAC_VER_61 },
+ */
/* RTL8117 */
{ 0x7cf, 0x54b, RTL_GIGA_MAC_VER_53 },
--
2.34.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] r8169: disable detection of chip version 60
2021-11-24 20:44 ` [PATCH net-next] r8169: disable detection of chip version 60 Heiner Kallweit
@ 2021-11-26 3:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-26 3:20 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: kuba, davem, nic_swsd, netdev
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 24 Nov 2021 21:44:40 +0100 you wrote:
> It seems only XID 609 made it to the mass market. Therefore let's
> disable detection of the other RTL8125a XID's. If nobody complains
> we can remove support for RTL_GIGA_MAC_VER_60 later.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/net/ethernet/realtek/r8169_main.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Here is the summary with links:
- [net-next] r8169: disable detection of chip version 60
https://git.kernel.org/netdev/net-next/c/4e9c91cf92ec
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-11-26 3:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-15 20:50 [PATCH net-next 0/3] r8169: disable detection of further chip versions that didn't make it to the mass market Heiner Kallweit
2021-11-15 20:51 ` [PATCH net-next 1/3] r8169: disable detection of chip versions 49 and 50 Heiner Kallweit
2021-11-15 20:51 ` [PATCH net-next 2/3] r8169: disable detection of chip version 45 Heiner Kallweit
2021-11-15 20:52 ` [PATCH net-next 3/3] r8169: disable detection of chip version 41 Heiner Kallweit
2021-11-17 3:20 ` [PATCH net-next 0/3] r8169: disable detection of further chip versions that didn't make it to the mass market patchwork-bot+netdevbpf
2021-11-24 20:44 ` [PATCH net-next] r8169: disable detection of chip version 60 Heiner Kallweit
2021-11-26 3:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).