Netdev List
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Michal Kubiak <michal.kubiak@intel.com>
Cc: <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
	Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
	Karol Kolacinski <karol.kolacinski@intel.com>,
	Grzegorz Nitka <grzegorz.nitka@intel.com>,
	Michal Schmidt <mschmidt@redhat.com>,
	"Sergey Temerkhanov" <sergey.temerkhanov@intel.com>
Subject: Re: [PATCH iwl-net v2] ice: use DSN instead of PCI BDF for ice_adapter index
Date: Mon, 7 Apr 2025 10:15:28 -0700	[thread overview]
Message-ID: <770a44c6-c808-4b31-aaa5-be8e57fbbf53@intel.com> (raw)
In-Reply-To: <7f700a89-7058-4c16-b53a-2e84bbed8542@intel.com>



On 4/7/2025 6:30 AM, Przemek Kitszel wrote:
> On 4/7/25 13:42, Michal Kubiak wrote:
>> On Mon, Apr 07, 2025 at 01:20:05PM +0200, Przemek Kitszel wrote:
>>> Use Device Serial Number instead of PCI bus/device/function for
>>> index of struct ice_adapter.
>>> Functions on the same physical device should point to the very same
>>> ice_adapter instance.
>>>
>>> This is not only simplification, but also fixes things up when PF
>>> is passed to VM (and thus has a random BDF).
>>>
>>> Suggested-by: Jacob Keller <jacob.e.keller@intel.com>
>>> Suggested-by: Jakub Kicinski <kuba@kernel.org>
>>> Suggested-by: Jiri Pirko <jiri@resnulli.us>
>>> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
>>> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>>> ---
>>> CC: Karol Kolacinski <karol.kolacinski@intel.com>
>>> CC: Grzegorz Nitka <grzegorz.nitka@intel.com>
>>> CC: Michal Schmidt <mschmidt@redhat.com>
>>> CC: Sergey Temerkhanov <sergey.temerkhanov@intel.com>
>>>
>>> v2:
>>>   - target to -net (Jiri)
>>
>> Missing "Fixes" tag? (After retargetting to -net).
>>
>> Thanks,
>> Michal
> 
> oh, thanks, I wonder if our pw will pick the tag, if not, I will resend
> 
> Fixes: 0e2bddf9e5f9 ("ice: add ice_adapter for shared data across PFs on 
> the same NIC")

I don't believe it does, but I can add it in. No need to resend.

Thanks,
Tony


  reply	other threads:[~2025-04-07 17:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 11:20 [PATCH iwl-net v2] ice: use DSN instead of PCI BDF for ice_adapter index Przemek Kitszel
2025-04-07 11:42 ` Michal Kubiak
2025-04-07 13:30   ` Przemek Kitszel
2025-04-07 17:15     ` Tony Nguyen [this message]
2025-04-07 12:03 ` Jiri Pirko
2025-04-07 13:26   ` Przemek Kitszel
2025-04-07 20:39 ` kernel test robot
2025-04-08  1:18 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=770a44c6-c808-4b31-aaa5-be8e57fbbf53@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=aleksandr.loktionov@intel.com \
    --cc=grzegorz.nitka@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jiri@resnulli.us \
    --cc=karol.kolacinski@intel.com \
    --cc=kuba@kernel.org \
    --cc=michal.kubiak@intel.com \
    --cc=mschmidt@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=sergey.temerkhanov@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox