From: Florian Fainelli <f.fainelli@gmail.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org
Cc: davem@davemloft.net, andrew@lunn.ch
Subject: Re: [PATCH net-next 09/12] net: dsa: b53: Wire-up EEE
Date: Mon, 18 Sep 2017 15:34:16 -0700 [thread overview]
Message-ID: <77a80a64-7840-861d-a3ec-5e2efbfe0d8c@gmail.com> (raw)
In-Reply-To: <87mv5r1vzx.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
On 09/18/2017 03:29 PM, Vivien Didelot wrote:
> Hi Florian,
>
> Florian Fainelli <f.fainelli@gmail.com> writes:
>
>> @@ -1000,6 +1005,9 @@ static void b53_adjust_link(struct dsa_switch *ds, int port,
>> b53_write8(dev, B53_CTRL_PAGE, po_reg, gmii_po);
>> }
>> }
>> +
>> + /* Re-negotiate EEE if it was enabled already */
>> + p->eee_enabled = b53_eee_init(ds, port, phydev);
>> }
>
> Same here, I think we can move this up to DSA core, maybe with a
> eee_enabled mask in dsa_switch or a bool in dsa_port.
This can be done as a subsequent patch, sure.
--
Florian
next prev parent reply other threads:[~2017-09-18 22:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 21:41 [PATCH net-next 00/12] net: dsa: b53/bcm_sf2 cleanups Florian Fainelli
2017-09-18 21:41 ` [PATCH net-next 01/12] net: dsa: b53: Remove is_cpu_port() Florian Fainelli
2017-09-18 21:44 ` Vivien Didelot
2017-09-18 21:41 ` [PATCH net-next 02/12] net: dsa: b53: Make b53_enable_cpu_port() take a port argument Florian Fainelli
2017-09-18 21:46 ` Vivien Didelot
2017-09-18 21:41 ` [PATCH net-next 03/12] net: dsa: b53: Defer port enabling to calling port_enable Florian Fainelli
2017-09-18 21:53 ` Vivien Didelot
2017-09-18 21:41 ` [PATCH net-next 04/12] net: dsa: bcm_sf2: " Florian Fainelli
2017-09-18 21:54 ` Vivien Didelot
2017-09-18 21:41 ` [PATCH net-next 05/12] net: dsa: b53: Use a macro to define I/O operations Florian Fainelli
2017-09-18 22:12 ` Vivien Didelot
2017-09-19 12:53 ` David Laight
2017-09-19 14:19 ` Vivien Didelot
2017-09-19 14:29 ` Florian Fainelli
2017-09-19 16:14 ` David Laight
2017-09-18 21:41 ` [PATCH net-next 06/12] net: dsa: b53: Move Broadcom header setup to b53 Florian Fainelli
2017-09-18 22:14 ` Vivien Didelot
2017-09-18 21:41 ` [PATCH net-next 07/12] net: dsa: b53: Define EEE register page Florian Fainelli
2017-09-18 21:41 ` [PATCH net-next 08/12] net: dsa: b53: Move EEE functions to b53 Florian Fainelli
2017-09-18 22:27 ` Vivien Didelot
2017-09-18 22:33 ` Florian Fainelli
2017-09-18 21:41 ` [PATCH net-next 09/12] net: dsa: b53: Wire-up EEE Florian Fainelli
2017-09-18 22:29 ` Vivien Didelot
2017-09-18 22:34 ` Florian Fainelli [this message]
2017-09-18 21:41 ` [PATCH net-next 10/12] net: dsa: b53: Export b53_imp_vlan_setup() Florian Fainelli
2017-09-18 21:41 ` [PATCH net-next 11/12] net: dsa: bcm_sf2: Use SF2_NUM_EGRESS_QUEUES for CFP Florian Fainelli
2017-09-18 21:41 ` [PATCH net-next 12/12] net: dsa: bcm_sf2: Utilize b53_{enable,disable}_port Florian Fainelli
2017-09-18 21:46 ` [PATCH net-next 00/12] net: dsa: b53/bcm_sf2 cleanups Florian Fainelli
2017-09-18 23:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77a80a64-7840-861d-a3ec-5e2efbfe0d8c@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).