From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 426583D9DDD for ; Mon, 27 Apr 2026 18:27:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777314440; cv=none; b=sHrgnamlTvnPhbh0doq3llOcuvj3JSliHvxk2OwKlfqdWbzhVxHtaYVdNEqYT4ANvUbKXiZ1TBTBq1cjCe230ZYyhoNUezqskKocQWRMOGA8cTVp9zsyi7k5f6pRoJ5xykKM2RAAZwG/JiHYFMZi4iv5aH/JLlLQ+84VeLXMlfQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777314440; c=relaxed/simple; bh=hfkSb5iSK+jnG60DLGgd+UagdkvWshNa7oLEFPu+t10=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bUQlnSDkpNyqB+QgquHNXXtN01mMiL3T7voeLmuhMJghs8fmAFpINd4a3DrcTu3uemE+WqD2V59JswbQjO+uV6sf4bHE6jwfVJKxqe8xwkP2J7de9+sNSYr0DGkhLtC3wxq08/uHwTEVY4c7xyfYffNph1LBfceOmduUiBAP1xE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L8HK9Rkg; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L8HK9Rkg" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-479d4df9035so4545047b6e.0 for ; Mon, 27 Apr 2026 11:27:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777314437; x=1777919237; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qUxrFoC8fiASca5qWozFg3oZ8Q9N01+/TQY2br6q3VU=; b=L8HK9RkgWrv6nUTzfogIxwsJdEHW+phreVVAqCTMP7+x4J8+w77VbeVmGYbQhtC6hx ZuHPtkESsyJr8hvj5amfMql/9w27Fpc4XBODbQkLXCFtJgDJ5DKod/FxPwk9NVSLkL2Q P5S4x/fgsV0i1w8jilvdxasdIPPQC1T22kdswSWrsMn2kJ+nzejAhTDQeinmc2wgicaI PoihBmqT1g0ozW7vbSyrqNyM6r3BDMZVHid7OFif+iOlzI7x1uM6movOkb8Ly33HutLG MLlbPlPfp+mlopj6hEe2CAgtyPzJOBFl+TUYu38CJ0nebGIA0o0ui3DXRQmvjSGcBZif YqIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777314437; x=1777919237; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qUxrFoC8fiASca5qWozFg3oZ8Q9N01+/TQY2br6q3VU=; b=VxnXxwlyXDOKqxpr3o+cSeRD2hDh1YUGkYCqoDIB/PZojQGTo0E5bc6gk5IrKxcoFx Yz/5hgGtFjgstAv+hFc2jX4L+lsNC3BauC3fnZHullrYuJldqrk3Vf+RLio9bJu3dEaO XonnyFnc8MdetD/mPTdxXv2YVroP144vvl72P9uwOGvuFaoPPa8jAfUmSo4t378WrZ/E JM+fPoKTbTauiDnMrEIsRv4reBb65fiPh9tzW/2tyTL2dfU+cOvt/fxXNcEBHQ4wg+XX ZupRPqXEI1rV5X+HTvFIP8j6by3/O5193amaVJOIQNWJUCKJu52yWzFSGLwGGIoqW6NN RSiQ== X-Forwarded-Encrypted: i=1; AFNElJ9msFaQ8jDjyiS0iI7GXJtqIaWIk9msmtLkP8WVmSwxGUg9sN4Z7WYoyyk/w7wiDb0nFw9F5pQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwiMN//QB4v7/HoqLoWeoW56d4rnG8GVKSnh8QZ9XIpBXga2JJJ 2fj2e3plxWX2RXPPCDa9f0TS1OCTXYcE81KGcsdc/Y6kbln2XZkji/eB X-Gm-Gg: AeBDiet0qX7bAym9vyjysMu2AuCI89o7xOIYVd0gqyhFnHTZ2iQheNkYQAvXTS2RT+1 Mk6ZrLKtoukJC/uiHV41tqN2Q6ZEPv/8byeQ53mxx+YK9GTKhGqKbABvKMgD8zMMsnHmHoxUCr/ 5Aho5NK+HPoqXrivjsNcS3UplFlOAFaxgMeVNw6SGJ7DZeBkBvjzWyuCqGWKAdWsh4G7SIeMS0J dSmwxH/YLh1dl2SmFd/XhTsuA4KLLamG3LdHjYjak4XpcvTSZLH4agSprNwAypdFBCq9NPEHlkt 35lhC7ysUSGUVYSAAbfVkWnXHiL/Azt0x9RmdVTGiG5o4Ybw+nco/nSDtf+RYKmffM0B7dIalnJ G1AB5hnRHhgEn4txBAsK/sXcKLrLvP0qKP+F+8kOK6gsM/o+U4mGDQ2Qb8L+O+5GngsGHchJME+ yd3tXlF+F7+1T+TOfFvXyACapgJ61IeYdxV8MDQxGvP5zIfJ9dms8+bkG/WXmBQdy2dUo62oy/t qRAVzX7z5p0T4YfivB11AnmQ2RH X-Received: by 2002:a05:6808:3448:b0:472:c4ba:32d9 with SMTP id 5614622812f47-47c26cba3fdmr138293b6e.20.1777314437166; Mon, 27 Apr 2026 11:27:17 -0700 (PDT) Received: from ?IPV6:2601:282:1e02:1040:7006:cec4:dca9:62e0? ([2601:282:1e02:1040:7006:cec4:dca9:62e0]) by smtp.googlemail.com with ESMTPSA id 46e09a7af769-7de986a6da5sm124806a34.20.2026.04.27.11.27.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2026 11:27:16 -0700 (PDT) Message-ID: <77e1a762-e204-497b-b7cb-40d5a93f8ec7@gmail.com> Date: Mon, 27 Apr 2026 12:27:15 -0600 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 iproute2-next 1/4] rdma: Update headers Content-Language: en-US To: Stephen Hemminger , Chiara Meiohas Cc: leon@kernel.org, michaelgur@nvidia.com, jgg@nvidia.com, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, Patrisious Haddad References: <20260330173118.766885-1-cmeiohas@nvidia.com> <20260330173118.766885-2-cmeiohas@nvidia.com> <20260427112505.684c21f3@phoenix.local> From: David Ahern In-Reply-To: <20260427112505.684c21f3@phoenix.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 4/27/26 12:25 PM, Stephen Hemminger wrote: > On Mon, 30 Mar 2026 20:31:15 +0300 > Chiara Meiohas wrote: > >> From: Michael Guralnik >> >> Update rdma_netlink.h file up to kernel commit dbd0472fd7a5 >> ("RDMA/nldev: Expose kernel-internal FRMR pools in netlink") >> >> Signed-off-by: Michael Guralnik >> Reviewed-by: Patrisious Haddad >> Reviewed-by: Chiara Meiohas > > The upstream macro names changed, the iproute2 build is broken after > current headers sync. > > In file included from res.c:7: > res.h: In function ‘_res_frmr_pools’: > res.h:203:26: error: ‘RDMA_NLDEV_CMD_RES_FRMR_POOLS_GET’ undeclared (first use in this function); did you mean ‘RDMA_NLDEV_CMD_FRMR_POOLS_GET’? > 203 | RES_FUNC(res_frmr_pools, RDMA_NLDEV_CMD_RES_FRMR_POOLS_GET, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > res.h:56:44: note: in definition of macro ‘RES_FUNC’ > 56 | _command = res_get_command(command, rd); \ > | ^~~~~~~ > res.h:203:26: note: each undeclared identifier is reported only once for each function it appears in > 203 | RES_FUNC(res_frmr_pools, RDMA_NLDEV_CMD_RES_FRMR_POOLS_GET, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > res.h:56:44: note: in definition of macro ‘RES_FUNC’ > 56 | _command = res_get_command(command, rd); \ > | ^~~~~~~ Looks like the merged API does not have the _RES part of the uapi: kernel vs iproute2: @@ -590,19 +590,19 @@ /* * FRMR Pools attributes */ - RDMA_NLDEV_ATTR_FRMR_POOLS, /* nested table */ - RDMA_NLDEV_ATTR_FRMR_POOL_ENTRY, /* nested table */ - RDMA_NLDEV_ATTR_FRMR_POOL_KEY, /* nested table */ - RDMA_NLDEV_ATTR_FRMR_POOL_KEY_ATS, /* u8 */ - RDMA_NLDEV_ATTR_FRMR_POOL_KEY_ACCESS_FLAGS, /* u32 */ - RDMA_NLDEV_ATTR_FRMR_POOL_KEY_VENDOR_KEY, /* u64 */ - RDMA_NLDEV_ATTR_FRMR_POOL_KEY_NUM_DMA_BLOCKS, /* u64 */ - RDMA_NLDEV_ATTR_FRMR_POOL_QUEUE_HANDLES, /* u32 */ - RDMA_NLDEV_ATTR_FRMR_POOL_MAX_IN_USE, /* u64 */ - RDMA_NLDEV_ATTR_FRMR_POOL_IN_USE, /* u64 */ - RDMA_NLDEV_ATTR_FRMR_POOLS_AGING_PERIOD, /* u32 */ - RDMA_NLDEV_ATTR_FRMR_POOL_PINNED_HANDLES, /* u32 */ - RDMA_NLDEV_ATTR_FRMR_POOL_KEY_KERNEL_VENDOR_KEY, /* u64 */ + RDMA_NLDEV_ATTR_RES_FRMR_POOLS, /* nested table */ + RDMA_NLDEV_ATTR_RES_FRMR_POOL_ENTRY, /* nested table */ + RDMA_NLDEV_ATTR_RES_FRMR_POOL_KEY, /* nested table */ + RDMA_NLDEV_ATTR_RES_FRMR_POOL_KEY_ATS, /* u8 */ + RDMA_NLDEV_ATTR_RES_FRMR_POOL_KEY_ACCESS_FLAGS, /* u32 */ + RDMA_NLDEV_ATTR_RES_FRMR_POOL_KEY_VENDOR_KEY, /* u64 */ + RDMA_NLDEV_ATTR_RES_FRMR_POOL_KEY_NUM_DMA_BLOCKS, /* u64 */ + RDMA_NLDEV_ATTR_RES_FRMR_POOL_QUEUE_HANDLES, /* u32 */ + RDMA_NLDEV_ATTR_RES_FRMR_POOL_MAX_IN_USE, /* u64 */ + RDMA_NLDEV_ATTR_RES_FRMR_POOL_IN_USE, /* u64 */ + RDMA_NLDEV_ATTR_RES_FRMR_POOL_AGING_PERIOD, /* u32 */ + RDMA_NLDEV_ATTR_RES_FRMR_POOL_PINNED, /* u32 */ + RDMA_NLDEV_ATTR_RES_FRMR_POOL_KEY_KERNEL_VENDOR_KEY, /* u64 */ /*