From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 102D48F7E;
	Sun, 29 Oct 2023 21:08:25 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="dT0wlb9v"
Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab])
	by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54775BA;
	Sun, 29 Oct 2023 14:08:24 -0700 (PDT)
Received: from [192.168.1.90] (unknown [188.24.143.101])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	(Authenticated sender: cristicc)
	by madras.collabora.co.uk (Postfix) with ESMTPSA id DF7DD66072BB;
	Sun, 29 Oct 2023 21:08:20 +0000 (GMT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1698613702;
	bh=GoWKvXVCI2rJHZaaMlrQGK5PE/qto64zo6wfdhb04jw=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=dT0wlb9v/BSZdRvWw2CB4dPGTr65xipwdJ1ig9xIKIAkNUTEUjjERuC4H1MnIlY7L
	 YHVqnak1wmwv0EXm0xnTWi6h/oWfJWDY9vPtUIdO/y35OgL539uSZKuLgBtMtu9rTk
	 4cVIDn1O4skrL+tY/cy51u/S7uRJicQ3YklzkLXhl/E4nYfPvmEK70+ZlVyidteCH2
	 JVAbU2ipAXoL76QnyMj1A+SF3e/bwJXaouX2NNzCnpSd7zCjZGoNEaJ/T62NU5EvA/
	 5WI6l6YnPrfxwo3Y8GIsGmZhcTKDsddwcdCeFdiFLUzhh8y8MSrAunK7jm3x1cVhQU
	 AyaCOohAvr+6A==
Message-ID: <77ea127f-1040-489c-8ee3-d27df16fb995@collabora.com>
Date: Sun, 29 Oct 2023 23:08:18 +0200
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 02/12] dt-bindings: net: starfive,jh7110-dwmac: Drop
 superfluous select
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Emil Renner Berthing <kernel@esmil.dk>,
 Samin Guo <samin.guo@starfivetech.com>,
 Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt
 <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Alexandre Torgue <alexandre.torgue@foss.st.com>,
 Jose Abreu <joabreu@synopsys.com>,
 Maxime Coquelin <mcoquelin.stm32@gmail.com>,
 Richard Cochran <richardcochran@gmail.com>,
 Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com,
 linux-arm-kernel@lists.infradead.org, kernel@collabora.com
References: <20231029042712.520010-1-cristian.ciocaltea@collabora.com>
 <20231029042712.520010-3-cristian.ciocaltea@collabora.com>
 <9c9120d6-dd28-4b6d-be8d-46c0cab8f26a@linaro.org>
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
In-Reply-To: <9c9120d6-dd28-4b6d-be8d-46c0cab8f26a@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/29/23 13:18, Krzysztof Kozlowski wrote:
> On 29/10/2023 05:27, Cristian Ciocaltea wrote:
>> The usage of 'select' doesn't seem to have any influence on how this
>> binding schema is applied to the nodes, hence remove it.
>>
> 
> It has. Why do you think it doesn't? You should see new errors from
> dwmac schema.

This patch came as a result of testing both variants (w/ and w/o
'select') with several different compatible strings and seeing
consistent output:

- "starfive,jh7110-dwmac", "invalid";
- "starfive,jh7110-dwmac";
- "invalid", "snps,dwmac-5.20";
- "invalid"

Did I miss something?

Thanks for the review,
Cristian