From: Hannes Frederic Sowa <hannes@redhat.com>
To: Alexander Duyck <aduyck@mirantis.com>,
netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Cc: jesse@kernel.org, jbenc@redhat.com, alexander.duyck@gmail.com,
saeedm@mellanox.com, ariel.elior@qlogic.com, tom@herbertland.com,
Dept-GELinuxNICDev@qlogic.com, davem@davemloft.net,
eugenia@mellanox.com
Subject: Re: [net-next PATCH 02/15] net: Merge VXLAN and GENEVE push notifiers into a single notifier
Date: Mon, 13 Jun 2016 19:57:31 +0200 [thread overview]
Message-ID: <77eb25b2-d775-ec6f-c945-524d73113c96@redhat.com> (raw)
In-Reply-To: <20160613174806.15186.64702.stgit@localhost.localdomain>
Hi Alex,
very cool series!
On 13.06.2016 19:48, Alexander Duyck wrote:
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index d101e4d904ba..e959b6348f91 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1269,6 +1269,14 @@ struct net_device_ops {
> void (*ndo_del_geneve_port)(struct net_device *dev,
> sa_family_t sa_family,
> __be16 port);
> + void (*ndo_add_udp_enc_port)(struct net_device *dev,
> + sa_family_t sa_family,
> + __be16 port,
> + unsigned int type);
> + void (*ndo_del_udp_enc_port)(struct net_device *dev,
> + sa_family_t sa_family,
> + __be16 port,
> + unsigned int type);
> void* (*ndo_dfwd_add_station)(struct net_device *pdev,
> struct net_device *dev);
> void (*ndo_dfwd_del_station)(struct net_device *pdev,
What do you think about adding a struct as argument to
ndo_*_udp_enc_port? As a result we can much easier add new fields in
case future NICs allow us to e.g. specify a bound ip address?
Thanks,
Hannes
next prev parent reply other threads:[~2016-06-13 17:57 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 17:47 [net-next PATCH 00/15] Future-proof tunnel offload handlers Alexander Duyck
2016-06-13 17:47 ` [net-next PATCH 01/15] net: Combine GENEVE and VXLAN port offload notifiers into single functions Alexander Duyck
2016-06-13 19:55 ` Tom Herbert
2016-06-13 20:24 ` Alexander Duyck
2016-06-13 20:36 ` Tom Herbert
2016-06-13 21:51 ` Alexander Duyck
2016-06-13 22:17 ` Tom Herbert
2016-06-13 23:12 ` Alexander Duyck
2016-06-14 0:28 ` Tom Herbert
2016-06-14 2:50 ` Alexander Duyck
2016-06-15 7:22 ` David Miller
2016-06-15 16:12 ` Tom Herbert
2016-06-13 17:48 ` [net-next PATCH 02/15] net: Merge VXLAN and GENEVE push notifiers into a single notifier Alexander Duyck
2016-06-13 17:57 ` Hannes Frederic Sowa [this message]
2016-06-13 19:31 ` Tom Herbert
2016-06-13 19:47 ` Alexander Duyck
2016-06-13 21:08 ` Hannes Frederic Sowa
2016-06-13 21:58 ` Alexander Duyck
2016-06-13 20:03 ` [Intel-wired-lan] " kbuild test robot
2016-06-13 17:48 ` [net-next PATCH 03/15] bnx2x: Move all UDP port notifiers to single function Alexander Duyck
2016-06-13 18:48 ` [Intel-wired-lan] " kbuild test robot
2016-06-13 17:48 ` [net-next PATCH 04/15] bnxt: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port Alexander Duyck
2016-06-13 18:41 ` Jesse Gross
2016-06-13 19:14 ` Hannes Frederic Sowa
2016-06-13 19:16 ` Alex Duyck
2016-06-13 19:16 ` Michael Chan
2016-06-13 19:31 ` [Intel-wired-lan] " kbuild test robot
2016-06-13 19:45 ` kbuild test robot
2016-06-13 17:48 ` [net-next PATCH 05/15] benet: " Alexander Duyck
2016-06-13 17:48 ` [net-next PATCH 06/15] fm10k: " Alexander Duyck
2016-06-13 17:48 ` [net-next PATCH 07/15] i40e: Move all UDP port notifiers to single function Alexander Duyck
2016-06-13 17:48 ` [net-next PATCH 08/15] ixgbe: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port Alexander Duyck
2016-06-13 17:49 ` [net-next PATCH 09/15] mlx4_en: " Alexander Duyck
2016-06-13 17:49 ` [net-next PATCH 10/15] mlx5_en: " Alexander Duyck
2016-06-13 17:49 ` [net-next PATCH 11/15] nfp: " Alexander Duyck
2016-06-13 17:49 ` [net-next PATCH 12/15] qede: Move all UDP port notifiers to single function Alexander Duyck
2016-06-13 17:49 ` [net-next PATCH 13/15] qlcnic: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port Alexander Duyck
2016-06-13 17:49 ` [net-next PATCH 14/15] net: Remove deprecated tunnel specific UDP offload functions Alexander Duyck
2016-06-13 17:50 ` [net-next PATCH 15/15] vxlan: Add new UDP encapsulation offload type for VXLAN-GPE Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77eb25b2-d775-ec6f-c945-524d73113c96@redhat.com \
--to=hannes@redhat.com \
--cc=Dept-GELinuxNICDev@qlogic.com \
--cc=aduyck@mirantis.com \
--cc=alexander.duyck@gmail.com \
--cc=ariel.elior@qlogic.com \
--cc=davem@davemloft.net \
--cc=eugenia@mellanox.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jbenc@redhat.com \
--cc=jesse@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).