From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH net-next] net: bridge: use rhashtable for fdbs Date: Tue, 12 Dec 2017 20:18:19 +0200 Message-ID: <77f67d9a-8fef-0758-fdbe-9db7555f32d6@cumulusnetworks.com> References: <1513087370-4791-1-git-send-email-nikolay@cumulusnetworks.com> <20171212100224.1aa33a96@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, roopa@cumulusnetworks.com, srn@prgmr.com, davem@davemloft.net To: Stephen Hemminger Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:39833 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752386AbdLLSSX (ORCPT ); Tue, 12 Dec 2017 13:18:23 -0500 Received: by mail-wm0-f66.google.com with SMTP id i11so468855wmf.4 for ; Tue, 12 Dec 2017 10:18:22 -0800 (PST) In-Reply-To: <20171212100224.1aa33a96@xeon-e3> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 12/12/17 20:02, Stephen Hemminger wrote: > On Tue, 12 Dec 2017 16:02:50 +0200 > Nikolay Aleksandrov wrote: > >> + memcpy(__entry->addr, f->key.addr.addr, ETH_ALEN); > > Maybe use ether_addr_copy() here? > This is an unrelated cleanup, the code in question was already like that. I can post a separate patch to turn these into ether_addr_copy().