From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] net: enable RPS on vlan devices Date: Wed, 10 Oct 2018 11:32:48 -0700 Message-ID: <78333418-4e54-8b58-288f-9b57e0054323@gmail.com> References: <1539132062-4348-1-git-send-email-shannon.nelson@oracle.com> <36675e01-e9be-2464-2ee1-2409ebc22223@oracle.com> <6b6794f4-fa61-a9bc-43ed-3c62eb680498@gmail.com> <6d7227d4-a7e0-0979-42bc-c7af61b35192@oracle.com> <13b1a780-ebde-3f0c-65f3-72157bc23690@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: silviu.smarandache@oracle.com To: Shannon Nelson , davem@davemloft.net, netdev@vger.kernel.org Return-path: Received: from mail-lj1-f194.google.com ([209.85.208.194]:44698 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726525AbeJKB4R (ORCPT ); Wed, 10 Oct 2018 21:56:17 -0400 Received: by mail-lj1-f194.google.com with SMTP id v6-v6so5805748ljc.11 for ; Wed, 10 Oct 2018 11:32:54 -0700 (PDT) In-Reply-To: <13b1a780-ebde-3f0c-65f3-72157bc23690@oracle.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/10/2018 11:23 AM, Shannon Nelson wrote: > For that matter, lots of features are "default off" until someone configures them, and there are lots of features that are only used by a subset of users.  In this case, we're trying to use something that already exists and arguably is broken for the vlan case.  Are there some technical reasons why this is not a good solution? Simply code maintenance, and added cost for non vlan users. Adding extra tests might help your use-case, but is slowing down other cases. Since the need for new stuff will never end, really eBPF allow for arbitrary usage, without the need for review kernel patches and maintaining it for next 10 years.