From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH] net-sysfs: export gso_max_size attribute
Date: Fri, 24 Nov 2017 11:43:13 -0700
Message-ID: <786ae327-f709-d09c-ceae-5f4789d537a1@gmail.com>
References: <1511397041-27994-1-git-send-email-solio.sarabia@intel.com>
 <338121b9-5e71-be85-7faf-02dbba070df3@gmail.com>
 <1511548369.16595.4.camel@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: kys@microsoft.com, shiny.sebastian@intel.com,
        linux-kernel@vger.kernel.org
To: Eric Dumazet <eric.dumazet@gmail.com>,
        Solio Sarabia <solio.sarabia@intel.com>,
        netdev@vger.kernel.org, davem@daveloft.net,
        stephen@networkplumber.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f68.google.com ([74.125.83.68]:46756 "EHLO
        mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750739AbdKXSnQ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 24 Nov 2017 13:43:16 -0500
In-Reply-To: <1511548369.16595.4.camel@gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 11/24/17 11:32 AM, Eric Dumazet wrote:
> On Fri, 2017-11-24 at 10:14 -0700, David Ahern wrote:
>> On 11/22/17 5:30 PM, Solio Sarabia wrote:
>>> The netdevice gso_max_size is exposed to allow users fine-control
>>> on
>>> systems with multiple NICs with different GSO buffer sizes, and
>>> where
>>> the virtual devices like bridge and veth, need to be aware of the
>>> GSO
>>> size of the underlying devices.
>>>
>>> In a virtualized environment, setting the right GSO sizes for
>>> physical
>>> and virtual devices makes all TSO work to be on physical NIC,
>>> improving
>>> throughput and reducing CPU util. If virtual devices send buffers
>>> greater than what NIC supports, it forces host to do TSO for
>>> buffers
>>> exceeding the limit, increasing CPU utilization in host.
>>>
>>> Suggested-by: Shiny Sebastian <shiny.sebastian@intel.com>
>>> Signed-off-by: Solio Sarabia <solio.sarabia@intel.com>
>>> ---
>>
>> This should be added to rtnetlink rather than sysfs.
> 
> This is already exposed by rtnetlink [1]

It currently is read-only. This patch wants to control setting it.

> 
> Please lets not add yet another net-sysfs knob.

Which is my main point - no more sysfs files.