public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Bhaskar Chowdhury <unixbhaskar@gmail.com>,
	ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
	kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
	john.fastabend@gmail.com, kpsingh@kernel.org,
	davem@davemloft.net, kuba@kernel.org, hawk@kernel.org,
	netdev@vger.kernel.org, bpf@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: core: Few absolutely rudimentary typo fixes throughout the file filter.c
Date: Wed, 10 Mar 2021 22:12:43 -0800	[thread overview]
Message-ID: <786f4801-c41f-cddd-c855-b388ec026614@infradead.org> (raw)
In-Reply-To: <20210311055608.12956-1-unixbhaskar@gmail.com>

On 3/10/21 9:56 PM, Bhaskar Chowdhury wrote:
> 
> Trivial spelling fixes throughout the file.
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>

Hi Bhaskar,

FYI:

a. we accept British or American spellings
b. we accept one or two spaces after a period ('.') at the end of a sentence
c. we accept Oxford (serial) comma or not

> ---
>  net/core/filter.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 255aeee72402..931ee5f39ae7 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -2927,7 +2927,7 @@ BPF_CALL_4(bpf_msg_pop_data, struct sk_msg *, msg, u32, start,
>  	 *
>  	 * Then if B is non-zero AND there is no space allocate space and
>  	 * compact A, B regions into page. If there is space shift ring to
> -	 * the rigth free'ing the next element in ring to place B, leaving
> +	 * the right freeing the next element in ring to place B, leaving
>  	 * A untouched except to reduce length.
>  	 */
>  	if (start != offset) {
> @@ -3710,7 +3710,7 @@ static inline int __bpf_skb_change_tail(struct sk_buff *skb, u32 new_len,
>  	 * be the one responsible for writing buffers.
>  	 *
>  	 * It's really expected to be a slow path operation here for
> -	 * control message replies, so we're implicitly linearizing,
> +	 * control message replies, so we're implicitly linearising,
>  	 * uncloning and drop offloads from the skb by this.
>  	 */
>  	ret = __bpf_try_make_writable(skb, skb->len);
> @@ -3778,7 +3778,7 @@ static inline int __bpf_skb_change_head(struct sk_buff *skb, u32 head_room,
>  		 * allow to expand on mac header. This means that
>  		 * skb->protocol network header, etc, stay as is.
>  		 * Compared to bpf_skb_change_tail(), we're more
> -		 * flexible due to not needing to linearize or
> +		 * flexible due to not needing to linearise or
>  		 * reset GSO. Intention for this helper is to be
>  		 * used by an L3 skb that needs to push mac header
>  		 * for redirection into L2 device.
> --


-- 
~Randy


  reply	other threads:[~2021-03-11  6:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11  5:56 [PATCH] net: core: Few absolutely rudimentary typo fixes throughout the file filter.c Bhaskar Chowdhury
2021-03-11  6:12 ` Randy Dunlap [this message]
2021-03-11  6:21   ` Bhaskar Chowdhury

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=786f4801-c41f-cddd-c855-b388ec026614@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=unixbhaskar@gmail.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox