From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4E2FC47404 for ; Fri, 11 Oct 2019 23:10:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2691214E0 for ; Fri, 11 Oct 2019 23:10:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fQfyFxOi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726642AbfJKXKk (ORCPT ); Fri, 11 Oct 2019 19:10:40 -0400 Received: from mail-pg1-f174.google.com ([209.85.215.174]:41398 "EHLO mail-pg1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726354AbfJKXKk (ORCPT ); Fri, 11 Oct 2019 19:10:40 -0400 Received: by mail-pg1-f174.google.com with SMTP id t3so6603849pga.8 for ; Fri, 11 Oct 2019 16:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xEJH2gl5cxrVrDLezlRqga3pxzJNbjj6AIpbXqfXcs8=; b=fQfyFxOihRduLBYlEj83v3WGaLarfxggJPycculkjD5/QQ4JYK64EiTNh+iE75M7rz 5TLHn0N/4x1H47qmFsvjLOo+8Ro8uFoR7Qxv/1TPnDr7Uaqh+SAuuBZ9hOE6+n0WL4CW teAKyF1Y9SHSzqjDhMFIkjOc7whN0D2XJVjpI6IcMVzid1g1Hv/fGi1AnVy9q3jINR7+ mfFGONOKmI3BIhBYnvhrDq59Na5WXR2ZIvGEnUzPY/VYHjhizTpH+vVgUPPKqY7ZtYJm Hf9oBbjgDnzbjkw4GVRS4h8M1bCJ6BOC4MtNLUeuunIFtZiQpr1S6fNUvOrqANOi7ulb b/gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xEJH2gl5cxrVrDLezlRqga3pxzJNbjj6AIpbXqfXcs8=; b=Bixf7dg7BZGSdA244A0Eh8VtJ6Ehcp0pCK+L+hJcgSiLJcuBR0fb68qzoL0bUvjzH6 OIvpeRkkKIj8x5sHJMhSQ1RdRDcYOIr0weGRoWTX15/RKqNu8mqJzDHnkF7cvuOZ+FpP suDpN97mZh2jXds0A3EwmHJPCMDz23Yk0pwXedHXGs89pBBGjJo73A5qJ1BkGLK2+HRY 15P5Kx2PT1OvYgA7h2Z00OvJ4kKME0fDJS3ez/FWAInU14OaMvOKGbb3IQbU1Xck3ko8 XbfqVC/xRjgFWQ3VCQw8q5ZxvIYTSaMfPfXpXcqjJ4o58Q4rP3+kTK5W/d8xhPd24cRc Hmyw== X-Gm-Message-State: APjAAAXXGMOBXR7lbKM4U7jbu8vosj9GFKI7H4S1uDpZYW0YYkmWLEDb l+wiZYWPlqaNP/HmxiIwzzk= X-Google-Smtp-Source: APXvYqyWwi7hMXOGDpdsWVyYeVfkPRLIlzxI//2fB3OJhRNkKulfyB5HsJmMQMEYFewxBvPFxqTztQ== X-Received: by 2002:a17:90a:23b0:: with SMTP id g45mr19481802pje.127.1570835439951; Fri, 11 Oct 2019 16:10:39 -0700 (PDT) Received: from dahern-DO-MB.local ([2601:282:800:fd80:d0e9:88fb:a643:fda7]) by smtp.googlemail.com with ESMTPSA id h186sm15804343pfb.63.2019.10.11.16.10.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Oct 2019 16:10:38 -0700 (PDT) Subject: Re: [patch net-next v2 2/4] devlink: propagate extack down to health reporter ops To: Johannes Berg , Jakub Kicinski , Jiri Pirko , davem@davemloft.net, "dsahern@gmail.com" Cc: netdev@vger.kernel.org, ayal@mellanox.com, moshe@mellanox.com, eranbe@mellanox.com, mlxsw@mellanox.com References: <20191010131851.21438-1-jiri@resnulli.us> <20191010131851.21438-3-jiri@resnulli.us> <20191010190429.4511a8de@cakuba.netronome.com> <4aba888eb7ae08b446aa1140df729bca93cb0d33.camel@sipsolutions.net> From: David Ahern Message-ID: <7889db74-817c-9558-f86f-a4e4c829c1fb@gmail.com> Date: Fri, 11 Oct 2019 17:10:35 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <4aba888eb7ae08b446aa1140df729bca93cb0d33.camel@sipsolutions.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 10/11/19 12:45 AM, Johannes Berg wrote: > So to me this looks fine. > > I don't really share the concern about extack being netlink specific and > then using it here - it ultimately doesn't matter whether this thing is > called "netlink_extack" or "extended_error_reporting", IMHO. +1