From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] net: init sk_cookie for inet socket Date: Mon, 23 Apr 2018 09:09:34 -0700 Message-ID: <788ce3f1-6534-5c2e-1870-5ebd8ea4ae7f@gmail.com> References: <1524405004-10960-1-git-send-email-laoar.shao@gmail.com> <20180423.115821.640630949143585629.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: eric.dumazet@gmail.com, alexei.starovoitov@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: David Miller , laoar.shao@gmail.com Return-path: In-Reply-To: <20180423.115821.640630949143585629.davem@davemloft.net> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 04/23/2018 08:58 AM, David Miller wrote: > From: Yafang Shao > Date: Sun, 22 Apr 2018 21:50:04 +0800 > >> With sk_cookie we can identify a socket, that is very helpful for >> traceing and statistic, i.e. tcp tracepiont and ebpf. >> So we'd better init it by default for inet socket. >> When using it, we just need call atomic64_read(&sk->sk_cookie). >> >> Signed-off-by: Yafang Shao > > Applied, thank you. > This is adding yet another atomic_inc on a global cache line. Most applications do not need the cookie being ever set. The existing mechanism was fine. Set it on demand.