From: Andrew Lunn <andrew@lunn.ch>
To: Markus Stockhausen <markus.stockhausen@gmx.de>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, chris.packham@alliedtelesis.co.nz,
daniel@makrotopia.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v14 10/13] net: mdio: realtek-rtl9300: Open up C22 and C45 space in parallel
Date: Tue, 18 Aug 2026 21:32:17 +0200 [thread overview]
Message-ID: <789b5b28-e9af-4b8b-a674-6aafe8a16478@lunn.ch> (raw)
In-Reply-To: <073901dd2f39$4e234ac0$ea69e040$@gmx.de>
On Tue, Aug 18, 2026 at 07:44:58PM +0200, Markus Stockhausen wrote:
> > Von: Andrew Lunn <andrew@lunn.ch>
> > Gesendet: Montag, 17. August 2026 22:32
> > An: Markus Stockhausen <markus.stockhausen@gmx.de>
> > Betreff: Re: [PATCH net-next v14 10/13] net: mdio: realtek-rtl9300: Open
> up C22 and C45 space in parallel
> > ...
> > > Until now we never encountered any of these PHYs in scope
> > > (RTL8218x octa port) outside of the Realtek RTL83xx/RTL93xx
> > > ecosystem.
> >
> > Is the ID in registers 2 and 2 specific to the RTL83xx/RTL93xx ? That
> > would make thinks simple.
>
> There is no difference in the ID registers of the RTL8218 that
> is attached to RTL83xx/RTL93xx or to possible other SOCs.
> The RTL8218 series has a lot in common with the lower port
> designs (e.g. RTL8211). They are driven by dual QSGMII and
> can be attached to any non Realtek SOC.
>
> If upstream rtlgen_read_mmd() is not the proper way then
> I must think about it. But that needs to wait a bit ...
I _think_ this becomes an issue when you have working C45 over C22,
but no C45. I can think of two solutions:
1. rtlgen_read_mmd() pokes around in the bus to find out if C45 is
supported, and if not, do C45 over C22.
2. When dealing with this horribly broken hardware polling, you trap
read/writes to C45 over C22 and emulate them using C45. That at least
keeps the workaround where it belongs, in the broken MDIO bus driver,
rather than the PHY driver.
Andrew
next prev parent reply other threads:[~2026-08-18 19:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 16:26 [PATCH net-next v14 00/13] net: mdio: realtek-rtl9300: Add RTL83xx support Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 01/13] dt-bindings: net: realtek,rtl9301-mdio: Add RTL83xx series Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 02/13] net: mdio: realtek-rtl9300: Add polling documentation Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 03/13] net: mdio: realtek-rtl9300: deny C45 over C22 access Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 04/13] net: phy: add phy_detach_internal() helper Markus Stockhausen
2026-08-17 16:41 ` Andrew Lunn
2026-08-17 16:26 ` [PATCH net-next v14 05/13] net: phy: add (*notify_phy_attach/detach)() hooks to struct mii_bus Markus Stockhausen
2026-08-17 16:46 ` Andrew Lunn
2026-08-17 16:26 ` [PATCH net-next v14 06/13] net: mdio: realtek-rtl9300: suppress sysfs bind/unbind attributes Markus Stockhausen
2026-08-17 16:47 ` Andrew Lunn
2026-08-17 16:26 ` [PATCH net-next v14 07/13] net: mdio: realtek-rtl9300: Configure hardware polling during probing Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 08/13] net: mdio: realtek-rtl9300: Add page tracking Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 09/13] net: mdio: realtek-rtl9300: Increase MDIO timeout Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 10/13] net: mdio: realtek-rtl9300: Open up C22 and C45 space in parallel Markus Stockhausen
2026-08-17 17:03 ` Andrew Lunn
2026-08-17 17:29 ` AW: " Markus Stockhausen
2026-08-17 19:35 ` Andrew Lunn
2026-08-17 20:05 ` AW: " Markus Stockhausen
2026-08-17 20:10 ` Andrew Lunn
2026-08-17 20:25 ` AW: " Markus Stockhausen
2026-08-17 20:31 ` Andrew Lunn
2026-08-18 17:44 ` AW: " Markus Stockhausen
2026-08-18 19:32 ` Andrew Lunn [this message]
2026-08-17 16:26 ` [PATCH net-next v14 11/13] net: mdio: realtek-rtl9300: Add support for RTL838x Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 12/13] net: mdio: realtek-rtl9300: Add support for RTL839x Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 13/13] net: mdio: realtek-rtl9300: reword Kconfig and module description Markus Stockhausen
2026-08-17 17:25 ` [PATCH net-next v14 00/13] net: mdio: realtek-rtl9300: Add RTL83xx support Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=789b5b28-e9af-4b8b-a674-6aafe8a16478@lunn.ch \
--to=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=markus.stockhausen@gmx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox