From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH iproute2-next] tc: red: allow setting th_min and th_max to the same value Date: Fri, 19 Jan 2018 12:37:19 -0800 Message-ID: <78b62f7d-21be-d6c8-06ef-ae2200a75afa@gmail.com> References: <20180116230850.25802-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, oss-drivers@netronome.com To: Jakub Kicinski , stephen@networkplumber.org Return-path: Received: from mail-pg0-f42.google.com ([74.125.83.42]:35330 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756172AbeASUhV (ORCPT ); Fri, 19 Jan 2018 15:37:21 -0500 Received: by mail-pg0-f42.google.com with SMTP id d6so2280381pgv.2 for ; Fri, 19 Jan 2018 12:37:21 -0800 (PST) In-Reply-To: <20180116230850.25802-1-jakub.kicinski@netronome.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/16/18 3:08 PM, Jakub Kicinski wrote: > Setting th_min and th_max to the same value may be useful for DCTCP > deployments. The original DCTCP paper describes it as a simplest way > of achieving simple ECN threshold marking. Indeed, there doesn't seem > to be any simpler qdisc in Linux which would allow such a setup today. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Dirk van der Merwe > --- > Or should I go ahead and add a DCTCP qdisc? :) > > tc/tc_red.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > applied to iproute2-next