From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F4173B5303; Thu, 26 Feb 2026 16:18:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772122729; cv=none; b=E/n7YWMBS50Vxh91+uNt2xaYrPoCoF7Sc3nBrgx+lUp67Spb5Mp49N5eL3X02nws3V5mihasl6focDPeNj9BONH2Vbp9o/oybrKiNo+oXdsWJ9Hp+0nQfkdVB76BWhq1XoGQOEC/c6PX57HAPN4rd/0FK8ujzI12prLIcWWq1eE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772122729; c=relaxed/simple; bh=kxUP9RO43PuNS5icnrQd14OoirwDeG69E+sv7gAMhJg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jwj7Ee6Yfg/x9B7H96KURSVb6vCaDLGD4/S/BBcOR44VKo+8A86PmybZDnE0QozEhNCjmGe9W5fkIglgQy6WeBfJ9X0F5/BWhCdgBRJO/FQNhJJRcFsPG6Nk+VDWAtob/e/B4MtQyk31nKZ9KJsM/L554qQ7qpRyK+nwTv9wPRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TfrIh+Gz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TfrIh+Gz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39242C116C6; Thu, 26 Feb 2026 16:18:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772122728; bh=kxUP9RO43PuNS5icnrQd14OoirwDeG69E+sv7gAMhJg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TfrIh+GzhsVBuYvEDEtaeeQAYDMqnD3jNuyXS35/GwVy5XJ5a3V5Km1OA+i/1ETCf HO0VqwDS9sjnTf95VavzzBKR+9otFWpQhMCknaADzW0vY6djJlaVhpG8/Rsib9KdGA FJmGSV9zTzeWam2TZbJ6PWlYCXLr7JDj61IQKs4Pd7oHSScAnpVKp1Ut3mbCQdhmVT boYz/aTEAW3HNeF2p7+/F1WvonyiPYAxnkcwNd6KcHBRDbxiFF5I6CqtAZ2qMDBZhO 7bCZ8PpSkZx2g0/dKvD558iLlZiElKz1LuxHCjBXKU+cHEjt9St9AnZ6mekmzj4vXL MahvMUEOVv4PQ== Message-ID: <78b7e776-5e1e-4cbf-96ed-ece9549e5caa@kernel.org> Date: Thu, 26 Feb 2026 09:18:47 -0700 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 1/2] icmp: fix ICMP error source address when xfrm policy matches Content-Language: en-US To: Antony Antony , Jakub Kicinski , Steffen Klassert , netdev@vger.kernel.org Cc: "David S . Miller" , Eric Dumazet , Paolo Abeni , Herbert Xu , Shuah Khan , devel@linux-ipsec.org, Tobias Brunner , Simon Horman , Sabrina Dubroca , stable+noautosel@kernel.org, linux-kernel@vger.kernel.org References: <19a0156ff6e76baa323a81d710510d399a6ff63a.1772101380.git.antony.antony@secunet.com> From: David Ahern In-Reply-To: <19a0156ff6e76baa323a81d710510d399a6ff63a.1772101380.git.antony.antony@secunet.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/26/26 3:27 AM, Antony Antony wrote: > When an IPsec gateway generates an ICMP error (e.g., Destination Host > Unreachable), the source address incorrectly shows the unreachable > destination instead of the gateway's address. IPv6 behaves correctly. > > Before fix: > ping 10.1.6.3 > From 10.1.6.3 icmp_seq=1 Destination Host Unreachable > (wrong - 10.1.6.3 is the unreachable host) > > After fix: > ping 10.1.6.3 > From 10.1.5.2 icmp_seq=1 Destination Host Unreachable > (correct - 10.1.5.2 is the gateway) > > The fix removes the memcpy that overwrote fl4 with fl4_dec after > xfrm_lookup(). A follow-up commit adds a selftest. > > Fixes: 415b3334a21a ("icmp: Fix regression in nexthop resolution during replies.") > Cc: stable+noautosel@kernel.org # Avoid false positives in tests > Signed-off-by: Antony Antony > Acked-by: Tobias Brunner > --- > net/ipv4/icmp.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: David Ahern