From: Florian Fainelli <f.fainelli@gmail.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
vivien.didelot@savoirfairelinux.com, andrew@lunn.ch,
jiri@resnulli.us
Subject: Re: [PATCH net-next 3/4] net: switchdev: Add switchdev_port_bridge_getlink_deferred
Date: Mon, 9 Jan 2017 12:13:19 -0800 [thread overview]
Message-ID: <78bba92c-aa8e-ee1e-4b7a-3625d6f6309a@gmail.com> (raw)
In-Reply-To: <20170109201135.GE3771@localhost.localdomain>
On 01/09/2017 12:11 PM, Marcelo Ricardo Leitner wrote:
> On Mon, Jan 09, 2017 at 11:45:02AM -0800, Florian Fainelli wrote:
>> Add switchdev_port_bridge_getlink_deferred() which does a deferred
>> object dump operation, this is required for e.g: DSA switches which
>> typically have sleeping I/O operations which is incompatible with being
>> in atomic context obviously.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> struct switchdev_attr attr = {
>> .orig_dev = dev,
>> @@ -829,12 +841,49 @@ int switchdev_port_bridge_getlink(struct sk_buff *skb, u32 pid, u32 seq,
>> if (err && err != -EOPNOTSUPP)
>> return err;
>>
>> - return ndo_dflt_bridge_getlink(skb, pid, seq, dev, mode,
>> + return ndo_dflt_bridge_getlink(skb, pid, seq, d, mode,
>
> Was this s/dev/d/ by mistake?
No, it's not a mistake, it was made so that the function signature could
be within 80 columns.
--
Florian
next prev parent reply other threads:[~2017-01-09 20:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 19:44 [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA Florian Fainelli
2017-01-09 19:45 ` [PATCH net-next 1/4] net: switchdev: Prepare for deferred functions modifying objects Florian Fainelli
2017-01-09 19:45 ` [PATCH net-next 2/4] net: switchdev: Add object dump deferred operation Florian Fainelli
2017-01-09 19:45 ` [PATCH net-next 3/4] net: switchdev: Add switchdev_port_bridge_getlink_deferred Florian Fainelli
2017-01-09 20:11 ` Marcelo Ricardo Leitner
2017-01-09 20:13 ` Florian Fainelli [this message]
2017-01-09 20:28 ` Marcelo Ricardo Leitner
2017-01-09 20:29 ` Florian Fainelli
2017-01-10 0:25 ` kbuild test robot
2017-01-09 19:45 ` [PATCH net-next 4/4] net: dsa: Utilize switchdev_port_bridge_getlink_deferred() Florian Fainelli
2017-01-09 20:48 ` [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA Ido Schimmel
2017-01-09 20:56 ` Florian Fainelli
2017-01-09 21:14 ` Ido Schimmel
2017-01-09 21:23 ` Andrew Lunn
2017-01-09 21:29 ` Ido Schimmel
2017-01-10 12:08 ` Jiri Pirko
2017-01-10 13:25 ` Ido Schimmel
2017-01-10 14:18 ` Jiri Pirko
2017-01-10 16:08 ` Ido Schimmel
2017-01-10 16:13 ` Jiri Pirko
2017-01-11 1:42 ` Florian Fainelli
2017-01-11 14:59 ` Andrew Lunn
2017-01-09 21:19 ` Vivien Didelot
2017-01-11 1:26 ` David Miller
2017-01-09 21:05 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78bba92c-aa8e-ee1e-4b7a-3625d6f6309a@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).