From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Gilbert Adikankwu <gilbertadikankwu@gmail.com>,
Nam Cao <namcao@linutronix.de>
Cc: <outreachy@lists.linux.dev>, <manishc@marvell.com>,
<GR-Linux-NIC-Dev@marvell.com>, <coiby.xu@gmail.com>,
<gregkh@linuxfoundation.org>, <netdev@vger.kernel.org>,
<linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: qlge: Add bool type to qlge_idc_wait()
Date: Mon, 16 Oct 2023 16:19:09 +0200 [thread overview]
Message-ID: <78f321db-bc09-06e8-b4ef-ac56ab91e187@intel.com> (raw)
In-Reply-To: <ZSpIPippZFtMw2aG@gilbert-PC>
On 10/14/23 09:50, Gilbert Adikankwu wrote:
> On Sat, Oct 14, 2023 at 09:14:23AM +0200, Nam Cao wrote:
>> On Sat, Oct 14, 2023 at 08:58:13AM +0200, Nam Cao wrote:
>>> On Sat, Oct 14, 2023 at 07:11:59AM +0100, Gilbert Adikankwu wrote:
>>>> Reported by checkpatch:
>>>>
>>>> WARNING: else is not generally useful after a break or return
>>>>
>>>
>>> What checkpatch is telling you here is that the "else" is redundant and
>>> can be removed. Although your patch suppresses the warning, it makes the
>>> code messier :(
>>
>> Ah wait, after reading Julia's comment, I realize that the "else" is not
>> redundant at all. Seems like checkpatch.pl is lying. So ignore what I
>> said.
>
> Thanks
>
>
Could you consider fixing checkpatch instead?
next prev parent reply other threads:[~2023-10-16 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 6:11 [PATCH] staging: qlge: Add bool type to qlge_idc_wait() Gilbert Adikankwu
2023-10-14 6:23 ` Julia Lawall
2023-10-14 7:39 ` Gilbert Adikankwu
2023-10-14 6:58 ` Nam Cao
2023-10-14 7:14 ` Nam Cao
2023-10-14 7:50 ` Gilbert Adikankwu
2023-10-16 14:19 ` Przemek Kitszel [this message]
2023-10-17 4:21 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78f321db-bc09-06e8-b4ef-ac56ab91e187@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=coiby.xu@gmail.com \
--cc=gilbertadikankwu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manishc@marvell.com \
--cc=namcao@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).