Re: [PULL] Networking for v6.3

[Jacob Keller <jacob.e.keller@intel.com>]

On 2/22/2023 11:33 AM, Jakub Kicinski wrote:
> On Wed, 22 Feb 2023 20:07:21 +0100 Alexander Lobakin wrote:
>>> I suspect it would be as simple as adding a
>>>
>>>         depends on ICE != n
>>>
>>> to that thing, but I didn't get around to testing that. I thought it
>>> would be better to notify the guilty parties.  
>>
>> Patch is on its way already, it just drops the opt and uses CONFIG_GNSS
>> directly.
> 
> You got me slightly worried now. The overall idea of using Kconfig 
> to resolve the dependency and compile out the entire file was right.
> Are you planing to wrap the entire source in IS_REACHABLE() ?

No. The new solution guards the ice_gnss.o with

ice-$(CONFIG_GNSS) += ice_gnss.o

in the Makefile. This works correctly for enabling ice_gnss only if GNSS
is reachable.

Then we exchange the IS_ENABLED that was done only in the ice_gnss.h
header file with IS_REACHABLE(CONFIG_GNSS).

It's exactly the same number of checks as we had on CONFIG_ICE_GNSS but
without the extra unnecessary option, and it compiles  with at least the
following:

GNSS = Y, ICE = Y
GNSS = M, ICE = M
GNSS = M, ICE = Y (disables ice_gnss code)
GNSS = Y, ICE = M

Let me post the patch and we can discuss there.

Thanks,
Jake