From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 025C1C169C4 for ; Wed, 6 Feb 2019 07:37:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7BC9218A1 for ; Wed, 6 Feb 2019 07:37:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="a2bn3xSo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728166AbfBFHhk (ORCPT ); Wed, 6 Feb 2019 02:37:40 -0500 Received: from smtprelay.synopsys.com ([198.182.47.9]:45636 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727710AbfBFHhj (ORCPT ); Wed, 6 Feb 2019 02:37:39 -0500 Received: from mailhost.synopsys.com (badc-mailhost2.synopsys.com [10.192.0.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtprelay.synopsys.com (Postfix) with ESMTPS id 6979E24E28CE; Tue, 5 Feb 2019 23:37:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1549438659; bh=VRAkLo8nfTQtUMCX5zgSVoL3ANH3/ibyyUhfHe8ev6w=; h=Subject:To:CC:References:From:Date:In-Reply-To:From; b=a2bn3xSoGOuvcNaMAEYq7o8nDimS/S9J+PRL8cgtbG6niuuvdiMlroOynWzVmYPKD AV6/Ln3WHOFdQ3NWKrtDSAbpHMlTBKRZYZakJLSYLMnshfMGE093duVl36BOar52fN d3P+o6i9w7jf1ZnqZQLlI4bL18ZWx2IJgPl98IFeHabtiIl+aXLPJQibUXRyctoPDY xf+rAGjnqMUL8k6o2kHwoYua78CsvsaRjJUwu+fVRtB6z1wQBcyfoz8OPXDSwI8z7t P2G8sOxdy90rgL62tUxPaIL1DdF599gvPzLNUSVB4rwNXJG+iorTIV8wcRLbWfddsN cRhFHLif4YT5Q== Received: from US01WEHTC3.internal.synopsys.com (us01wehtc3.internal.synopsys.com [10.15.84.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id C570DA0066; Wed, 6 Feb 2019 07:37:38 +0000 (UTC) Received: from DE02WEHTCB.internal.synopsys.com (10.225.19.94) by US01WEHTC3.internal.synopsys.com (10.15.84.232) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 5 Feb 2019 23:37:38 -0800 Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by DE02WEHTCB.internal.synopsys.com (10.225.19.94) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 6 Feb 2019 08:37:37 +0100 Received: from [10.107.19.176] (10.107.19.176) by DE02WEHTCA.internal.synopsys.com (10.225.19.80) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 6 Feb 2019 08:37:37 +0100 Subject: Re: [PATCH net 0/3] net: stmmac: Misc fixes To: Niklas Cassel , Jose Abreu CC: , Joao Pinto , "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue , References: <20190205220544.GA25400@centauri.lan> From: Jose Abreu Message-ID: <7922f774-3717-0768-ecc6-f58e84120b4d@synopsys.com> Date: Wed, 6 Feb 2019 07:37:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190205220544.GA25400@centauri.lan> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.19.176] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Niklas, On 2/5/2019 10:05 PM, Niklas Cassel wrote: > On Wed, Jan 30, 2019 at 03:54:18PM +0100, Jose Abreu wrote: >> >> Some misc fixes for stmmac targeting -net. >> >> Cc: Joao Pinto >> Cc: David S. Miller >> Cc: Giuseppe Cavallaro >> Cc: Alexandre Torgue >> >> Jose Abreu (3): >> net: stmmac: Fallback to Platform Data clock in Watchdog conversion >> net: stmmac: Send TSO packets always from Queue 0 >> net: stmmac: Disable EEE mode earlier in XMIT callback > > Hello Jose, > > Thanks for your great work of improving the stmmac driver. > > Unfortunately, I'm seeing that a lot of important stmmac fixes > aren't getting backported to stable kernels. > > > I think that the problem is that a lot of stmmac commit messages do > not clearly indicate what happens if these patches are not included. > > See netdev FAQ: > > Q: I have created a network patch and I think it should be backported to > stable. Should I add a "Cc: stable@vger.kernel.org" like the references > in the kernel's Documentation/ directory say? > > A: No. See above answer. In short, if you think it really belongs in > stable, then ensure you write a decent commit log that describes who > gets impacted by the bugfix and how it manifests itself, and when the > bug was introduced. If you do that properly, then the commit will > get handled appropriately and most likely get put in the patchworks > stable queue if it really warrants it. I will try to add a Fixes tag and explain more carefully the next time. Sorry. > > > > Could you please tell me what happens if I don't include > "net: stmmac: Disable EEE mode earlier in XMIT callback" ? Probably a drop in performance. Not critical though. > > > likewise if I don't include "net: stmmac: Send TSO packets always from > Queue 0" ? In my tests I get a drop in performance also. > > I assume that I will get a TX timeout if I try to send a TSO packet > from a queue that does not support it? No. Packets will still be sent but they will not be TSO packets. > > Also, we already define the TX queues in the snps,mtl-tx-config: > Documentation/devicetree/bindings/net/stmmac.txt > > Wouldn't it be possible to add a snps,tso-capable property for each tx > queue node that supports tso? Yes but that would be more like a -next improvement. Thanks, Jose Miguel Abreu > > > Kind regards, > Niklas > >> >> drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 14 ++++++++++---- >> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 17 +++++++++++++---- >> include/linux/stmmac.h | 1 + >> 3 files changed, 24 insertions(+), 8 deletions(-) >> >> -- >> 2.7.4 >>