netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Erni Sri Satya Vennela <ernis@linux.microsoft.com>,
	stephen@networkplumber.org, netdev@vger.kernel.org
Cc: haiyangz@microsoft.com, shradhagupta@linux.microsoft.com,
	ssengar@microsoft.com, ernis@microsoft.com
Subject: Re: [PATCH iproute2-next] iproute2: Add 'netshaper' command to 'ip link' for netdev shaping
Date: Mon, 28 Jul 2025 12:15:19 -0600	[thread overview]
Message-ID: <796ca41f-37a1-4bdb-9de2-e52a2c11ff49@gmail.com> (raw)
In-Reply-To: <1753694099-14792-1-git-send-email-ernis@linux.microsoft.com>

On 7/28/25 3:14 AM, Erni Sri Satya Vennela wrote:
> Add support for the netshaper Generic Netlink
> family to iproute2. Introduce a new subcommand to `ip link` for
> configuring netshaper parameters directly from userspace.
> 
> This interface allows users to set shaping attributes (such as speed)
> which are passed to the kernel to perform the corresponding netshaper
> operation.
> 
> Example usage:
> $ip link netshaper { set | get | delete } dev DEVNAME \
>                    handle scope SCOPE id ID \
>                    [ speed SPEED ]
> 
> Internally, this triggers a kernel call to apply the shaping
> configuration to the specified network device.
> 
> Currently, the tool supports the following functionalities:
> - Setting speed in Mbps, enabling bandwidth clamping for
>   a network device that support netshaper operations.
> - Deleting the current configuration.
> - Querying the existing configuration.
> 
> Additional netshaper operations will be integrated into the tool
> as per requirement.
> 
> This change enables easy and scriptable configuration of bandwidth
> shaping for  devices that use the netshaper Netlink family.
> 
> Corresponding net-next patches:
> 1) https://lore.kernel.org/all/cover.1728460186.git.pabeni@redhat.com/
> 2) https://lore.kernel.org/lkml/1750144656-2021-1-git-send-email-ernis@linux.microsoft.com/
> 
> Signed-off-by: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
> ---
>  include/uapi/linux/netshaper.h |  92 +++++++++++++++++

the file in the kernel tree is net_shaper.h? drop it from the patch and
ask for it to be added to the uapi files when posting the next version.


  parent reply	other threads:[~2025-07-28 18:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-28  9:14 [PATCH iproute2-next] iproute2: Add 'netshaper' command to 'ip link' for netdev shaping Erni Sri Satya Vennela
2025-07-28 18:13 ` Stephen Hemminger
2025-07-29 11:07   ` Erni Sri Satya Vennela
2025-07-28 18:15 ` David Ahern [this message]
2025-07-29 11:23   ` Erni Sri Satya Vennela
2025-07-29 15:20     ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=796ca41f-37a1-4bdb-9de2-e52a2c11ff49@gmail.com \
    --to=dsahern@gmail.com \
    --cc=ernis@linux.microsoft.com \
    --cc=ernis@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=netdev@vger.kernel.org \
    --cc=shradhagupta@linux.microsoft.com \
    --cc=ssengar@microsoft.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).