From: Florian Fainelli <f.fainelli@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
corbet@lwn.net, linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next] docs: netdev: clarify the need to sending reverts as patches
Date: Mon, 27 Mar 2023 12:19:14 -0700 [thread overview]
Message-ID: <7975a642-965b-81c7-d0e7-21e499b152ea@gmail.com> (raw)
In-Reply-To: <20230327172646.2622943-1-kuba@kernel.org>
On 3/27/23 10:26, Jakub Kicinski wrote:
> We don't state explicitly that reverts need to be submitted
> as a patch. It occasionally comes up.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: corbet@lwn.net
> CC: linux-doc@vger.kernel.org
> ---
> Documentation/process/maintainer-netdev.rst | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/process/maintainer-netdev.rst b/Documentation/process/maintainer-netdev.rst
> index e31d7a951073..f6983563ff06 100644
> --- a/Documentation/process/maintainer-netdev.rst
> +++ b/Documentation/process/maintainer-netdev.rst
> @@ -184,11 +184,18 @@ Handling misapplied patches
>
> Occasionally a patch series gets applied before receiving critical feedback,
> or the wrong version of a series gets applied.
> -There is no revert possible, once it is pushed out, it stays like that.
> +
> +Making the patch disappear once it is pushed out is not possible, the commit
> +history in netdev trees is stable.
I would write immutable instead of stable here to convey the idea that
there are no history rewrites once the tree is pushed out. With that:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2023-03-27 19:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 17:26 [PATCH net-next] docs: netdev: clarify the need to sending reverts as patches Jakub Kicinski
2023-03-27 17:52 ` Jacob Keller
2023-03-27 19:19 ` Florian Fainelli [this message]
2023-03-29 2:04 ` Jakub Kicinski
2023-03-29 7:00 ` patchwork-bot+netdevbpf
2023-03-29 9:04 ` Thorsten Leemhuis
2023-03-29 19:02 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7975a642-965b-81c7-d0e7-21e499b152ea@gmail.com \
--to=f.fainelli@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).