On Tuesday, 1 September 2026 15:59:58 CEST sashiko-bot@kernel.org wrote:
> [Severity: High]
> This isn't a bug introduced by this patch, but does the throughput comparison
> in batadv_v_neigh_cmp() overflow?
> 
> In batadv_v_neigh_cmp(), we have:
> 
>     ret = ifinfo1->bat_v.throughput - ifinfo2->bat_v.throughput;
> 
> If an interface is provisioned with a throughput override via netlink that
> exceeds the signed 32-bit maximum (2,147,483,647), subtracting a low or zero
> throughput interface from it causes this unsigned subtraction to overflow.
> 
> The result is implicitly cast to a signed 32-bit integer, turning it negative.
> 
> Will returning a negative value here incorrectly signal to callers that the
> optimal high-throughput path is worse, causing the mesh routing to prefer
> suboptimal or zero-throughput paths instead?

Out-of-scope for this patch. It isn't even touched in this patch.

Document it for interested contributors in 
https://www.open-mesh.org/issues/470

Regards,
	Sven