Re: [PATCH net-next v6 3/5] veth: add tx_timeout watchdog as BQL safety net

[Jesper Dangaard Brouer <hawk@kernel.org>]

On 04/06/2026 10.24, Paolo Abeni wrote:
> On 5/27/26 3:54 PM, hawk@kernel.org wrote:
>> @@ -1819,6 +1836,7 @@ static void veth_setup(struct net_device *dev)
>>   	dev->priv_destructor = veth_dev_free;
>>   	dev->pcpu_stat_type = NETDEV_PCPU_STAT_TSTATS;
>>   	dev->max_mtu = ETH_MAX_MTU;
>> +	dev->watchdog_timeo = msecs_to_jiffies(16000);
> 
> Since a repost is neede it could be possibly usedfull using a macro for
> the above constant and expanding the math leading to the actual value.

Makes sense to move to a DEFINE.
It might be practical to use in veth_set_coalesce() as I guess we should
enforce tx_coal to be less-than the timeout.

> Also possibly an additional + 1 to avoid a very unlikely false positive
> on exactly the maximum possible interval timer?

I don't think the +1 brings much value, because this timer is jiffies 
based so do don't expect to hit exact value anyhow.

--Jesper