From: David Ahern <dsahern@gmail.com>
To: netdev@vger.kernel.org, stephen@networkplumber.org
Subject: Re: [PATCH iproute2] lib: Dump ext-ack string by default
Date: Mon, 7 Aug 2017 13:36:49 -0600 [thread overview]
Message-ID: <79db9ff1-69c3-5a16-fb67-54f1b79eb3a5@gmail.com> (raw)
In-Reply-To: <1502134082-4602-1-git-send-email-dsahern@gmail.com>
On 8/7/17 1:28 PM, David Ahern wrote:
> @@ -99,7 +95,12 @@ static int nl_dump_ext_err(const struct nlmsghdr *nlh, nl_ext_ack_fn_t errfn)
> err_nlh = &err->msg;
> }
>
> - return errfn(errmsg, off, err_nlh);
> + if (errfn)
> + return errfn(errmsg, off, err_nlh);
> +
> + fprintf(stderr, "Error: %s\n", errmsg);
> +
> + return 1;
Dang it, missing an 'if (errmsg)' since it does not have to exist. Will
send a v2
prev parent reply other threads:[~2017-08-07 19:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 19:28 [PATCH iproute2] lib: Dump ext-ack string by default David Ahern
2017-08-07 19:36 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79db9ff1-69c3-5a16-fb67-54f1b79eb3a5@gmail.com \
--to=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox