public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jakub Vaněk" <linuxtardis@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
	Daniel Golle <daniel@makrotopia.org>,
	Qingfang Deng <dqfext@gmail.com>,
	SkyLake Huang <SkyLake.Huang@mediatek.com>,
	Frank <Frank.Sae@motor-comm.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Sai Krishna <saikrishnag@marvell.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v1] net: phy: motorcomm: yt8821: disable MDIO broadcast address 0
Date: Sun, 22 Feb 2026 20:12:24 +0100	[thread overview]
Message-ID: <79e33665-ff41-412d-ab17-154f6687233d@gmail.com> (raw)
In-Reply-To: <557033a0-e5c8-4384-8f40-21f37c2e7dc1@lunn.ch>

On 2/22/26 16:15, Andrew Lunn wrote:
> On Sun, Feb 22, 2026 at 10:52:28AM +0100, Jakub Vaněk wrote:
>> On 2/22/26 09:28, Russell King (Oracle) wrote:
>>> On Sun, Feb 22, 2026 at 05:22:55AM +0100, Jakub Vaněk wrote:
>>>> I had hoped this would not happen on the Cudy router. The MediaTek
>>>> Ethernet subsystem driver uses of_mdiobus_register(), so PHY address 0
>>>> should not be probed unless it is explicitly described in the device
>>>> tree. That said, I agree that with mdiobus_register() this would still
>>>> be an issue.
>>>>
>>>> I was also hoping that moving the internal PHY would provide more
>>>> flexibility in the device tree description of the YT8821. If the
>>>> workaround were implemented in U-Boot by writing YT8821 MDIO registers
>>>> at boot time, Linux would not be able to assert the YT8821 reset pin
>>>> without losing that workaround.
>>>
>>> Why would you want to assert the reset pin?
>>>
>>
>> I don't currently have a solid reason to assert the reset pin.
>> The two reasons I had in mind were mostly precautionary:
> 
> Being able to drive a PHY reset pin in Linux is relatively new. It was
> added in 2016. Before that, we lived without this feature. If
> anything, being able to reset the PHY causes more issues than it
> solves.
> 
> So unless the PHY is actually broken and needs a reset to make it
> work, it is probably better not to list the reset.

Thank you, that is encouraging. Handling the YT8821 PHY reset
and configuration in U-Boot should then indeed be sufficient.

Best regards,
Jakub


      reply	other threads:[~2026-02-22 19:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-21 23:46 [PATCH net v1] net: phy: motorcomm: yt8821: disable MDIO broadcast address 0 Jakub Vaněk
2026-02-22  0:16 ` Andrew Lunn
2026-02-23 20:06   ` Jakub Vaněk
2026-02-22  0:18 ` Russell King (Oracle)
2026-02-22  2:04   ` Jakub Vaněk
2026-02-22  2:32 ` Jakub Vaněk
2026-02-22  3:35   ` Andrew Lunn
2026-02-22  4:22     ` Jakub Vaněk
2026-02-22  8:28       ` Russell King (Oracle)
2026-02-22  9:52         ` Jakub Vaněk
2026-02-22 15:15           ` Andrew Lunn
2026-02-22 19:12             ` Jakub Vaněk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79e33665-ff41-412d-ab17-154f6687233d@gmail.com \
    --to=linuxtardis@gmail.com \
    --cc=Frank.Sae@motor-comm.com \
    --cc=SkyLake.Huang@mediatek.com \
    --cc=andrew@lunn.ch \
    --cc=daniel@makrotopia.org \
    --cc=davem@davemloft.net \
    --cc=dqfext@gmail.com \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saikrishnag@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox