Netdev List
 help / color / mirror / Atom feed
From: Igor Russkikh <irusskikh@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	"Ariel Elior" <aelior@marvell.com>,
	Michal Kalderon <mkalderon@marvell.com>,
	"Denis Bolotin" <dbolotin@marvell.com>,
	Jiri Pirko <jiri@resnulli.us>,
	"Alexander Lobakin" <alobakin@marvell.com>
Subject: Re: [EXT] Re: [PATCH v5 net-next 04/10] qed: implement devlink info request
Date: Tue, 4 Aug 2020 10:21:20 +0300	[thread overview]
Message-ID: <79e9a8ca-3c6b-8ded-8a6a-1f4455e4e752@marvell.com> (raw)
In-Reply-To: <20200803142951.4c92f1ee@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>


Hi Jakub,

On 04/08/2020 12:29 am, Jakub Kicinski wrote:

>> ~$ sudo ~/iproute2/devlink/devlink  dev info
>> pci/0000:01:00.0:
>>   driver qed
>>   serial_number REE1915E44552
> 
> Just to confirm - this is not:
> 
>    * - ``board.serial_number``
>      - Board serial number of the device.
> 
>        This is usually the serial number of the board, often available in
>        PCI *Vital Product Data*.

I'm not sure on difference between board. or just serial_number, but lspci
shows this ID as a part of vital product data.

Considering this you are right, its better to change to "board.serial_number".

>> Running FW (or fastpath FW) is an embedded microprogram implementing
>> all the packet processing, offloads, etc. This FW is being loaded
>> on each start by the driver from FW binary blob.
> 
> Sounds like you should use:
> 
> fw.app - Data path microcode controlling high-speed packet processing.

Thanks, agreed.

Jakub, David, I'll prepare v6. Should I postpone posting v6 until the next
cycle then?

Regards,
  Igor

  reply	other threads:[~2020-08-04  7:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-02 10:08 [PATCH v5 net-next 00/10] qed: introduce devlink health support Igor Russkikh
2020-08-02 10:08 ` [PATCH v5 net-next 01/10] qed: move out devlink logic into a new file Igor Russkikh
2020-08-02 10:08 ` [PATCH v5 net-next 02/10] qed/qede: make devlink survive recovery Igor Russkikh
2020-08-02 10:08 ` [PATCH v5 net-next 03/10] qed: fix kconfig help entries Igor Russkikh
2020-08-02 10:08 ` [PATCH v5 net-next 04/10] qed: implement devlink info request Igor Russkikh
2020-08-03 21:29   ` Jakub Kicinski
2020-08-04  7:21     ` Igor Russkikh [this message]
2020-08-02 10:08 ` [PATCH v5 net-next 05/10] qed: health reporter init deinit seq Igor Russkikh
2020-08-02 10:08 ` [PATCH v5 net-next 06/10] qed: use devlink logic to report errors Igor Russkikh
2020-08-02 10:08 ` [PATCH v5 net-next 07/10] qed*: make use of devlink recovery infrastructure Igor Russkikh
2020-08-02 10:08 ` [PATCH v5 net-next 08/10] qed: implement devlink dump Igor Russkikh
2020-08-02 10:08 ` [PATCH v5 net-next 09/10] qed: align adjacent indent Igor Russkikh
2020-08-02 10:08 ` [PATCH v5 net-next 10/10] qede: make driver reliable on unload after failures Igor Russkikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79e9a8ca-3c6b-8ded-8a6a-1f4455e4e752@marvell.com \
    --to=irusskikh@marvell.com \
    --cc=aelior@marvell.com \
    --cc=alobakin@marvell.com \
    --cc=davem@davemloft.net \
    --cc=dbolotin@marvell.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=mkalderon@marvell.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox