From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: RE: [PATCH net-next 0/6] net/ncsi: Allow enabling multiple packages & channels Date: Fri, 19 Oct 2018 21:38:47 +0000 Message-ID: <79ee8c9befaa40e781bfeba4ba25d396@AUSX13MPS302.AMER.DELL.COM> References: <20181018035917.19413-1-sam@mendozajonas.com> <20181018.155647.1045018243241594303.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: , , To: , Return-path: In-Reply-To: <20181018.155647.1045018243241594303.davem@davemloft.net> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Sam, When I run the testing (enable multi-package (package 0 and 1) and=20 multi-channel (channel 0 and 1 on both packages)), I see there are two chan= nels with TX enable. When I unplug/plug network cable, it seems the behavior is to keep one TX p= er package, is it the behavior you expect? All channels are behind the same et= h2, I would expect there is only one active TX. I create the below file to expose driver's status. RX and TX are printing=20 from the follow variables. nc->modes[NCSI_MODE_ENABLE].enable, nc->modes[NCSI_MODE_TX_ENABLE].enable, cat /sys/kernel/debug/ncsi_protocol/ncsi_device_status; IFIDX IFNAME NAME PID CID RX TX MP MC WP WC PS RU CR NQ =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D 2 eth2 ncsi0 000 000 1 1 1 1 1 1 1 1 1 0=20 2 eth2 ncsi1 000 001 1 0 1 1 1 1 1 1 1 0=20 2 eth2 ncsi2 001 000 1 1 1 1 1 1 1 1 1 0=20 2 eth2 ncsi3 001 001 1 0 1 1 1 1 1 1 1 0=20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D M: Multi-mode P: Package ID W: Whitelist C: Channel ID PS: Poll Status RU: Running CR: Carrier OK NQ: Queue Stopped Thanks, Justin From: Samuel Mendoza-Jonas Date: Thu, 18 Oct 2018 14:59:11 +1100 > This series extends the NCSI driver to configure multiple packages > and/or channels simultaneously. Since the RFC series this includes a few > extra changes to fix areas in the driver that either made this harder or > were roadblocks due to deviations from the NCSI specification. >=20 > Patches 1 & 2 fix two issues where the driver made assumptions about the > capabilities of the NCSI topology. > Patches 3 & 4 change some internal semantics slightly to make multi-mode > easier. > Patch 5 introduces a cleaner way of reconfiguring the NCSI configuration > and keeping track of channel states. > Patch 6 implements the main multi-package/multi-channel configuration, > configured via the Netlink interface. >=20 > Readers who have an interesting NCSI setup - especially multi-package > with HWA - please test! I think I've covered all permutations but I > don't have infinite hardware to test on.