From: YueHaibing <yuehaibing@huawei.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>
Subject: Re: net/arp: ARP cache aging failed.
Date: Thu, 15 Dec 2016 10:58:55 +0800 [thread overview]
Message-ID: <7a2e0ee3-e8db-0e5f-3d0d-64f6e6bf367c@huawei.com> (raw)
In-Reply-To: <alpine.LFD.2.11.1612142151340.1681@ja.home.ssi.bg>
On 2016/12/15 4:15, Julian Anastasov wrote:
>
> Hello,
>
> On Wed, 14 Dec 2016, YueHaibing wrote:
>
>> On 2016/11/26 4:40, Julian Anastasov wrote:
>>>
>>> So, the idea is to move TCP and other similar
>>> users to the new dst_confirm_sk() method. If other
>>> dst_confirm() users are left, they should be checked
>>> if dsts with rt_gateway = 0 can be wrongly used.
>>
>> Sorry for so late.
>
> In fact, I'm late too because I almost finished
> my changes, the only remaining part is the cxgb files...
>
>> Based on your ideas, I make a patch and test it for a while.
>
> The problem is that it is valid only for TCP.
> Also, this flag should be reset sometimes, eg. when sk dst
> changes...
>
>> It works for me.
>>
>> @@ -847,7 +847,7 @@ static int ping_v4_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)
>> return err;
>>
>> do_confirm:
>> - dst_confirm(&rt->dst);
>> + dst_confirm_sk(sk);
>
> MSG_CONFIRM from sendmsg needs special treatment. The
> problem is that UDP sending does not lock the socket, so I also
> added a skb flag to handle this situation in ip*_append_data.
> We do not want threaded application firing at different
> destinations to confirm the wrong neighbour. MSG_PROBE is
> another issue, the XFRM dst chaining, etc...
>
> I hope, I'll be ready this weekend with few patches
> that change all dst_confirm users... There I'll explain
> everything in detail.
>
> Regards
>
> --
> Julian Anastasov <ja@ssi.bg>
>
> .
>
Great, I'll be glad to do a testing.
prev parent reply other threads:[~2016-12-15 3:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 1:16 net/arp: ARP cache aging failed yuehaibing
2016-11-23 8:33 ` Julian Anastasov
2016-11-23 12:05 ` Eric Dumazet
2016-11-23 14:37 ` Hannes Frederic Sowa
2016-11-23 23:49 ` Eric Dumazet
2016-11-24 7:51 ` Julian Anastasov
2016-11-24 9:06 ` YueHaibing
2016-11-24 12:28 ` Hannes Frederic Sowa
2016-11-25 8:18 ` Julian Anastasov
2016-11-25 13:53 ` Hannes Frederic Sowa
2016-11-25 20:40 ` Julian Anastasov
2016-12-14 10:54 ` YueHaibing
2016-12-14 12:56 ` [PATCH] arp: do neigh confirm based on sk arg kbuild test robot
2016-12-14 13:37 ` kbuild test robot
2016-12-14 20:15 ` net/arp: ARP cache aging failed Julian Anastasov
2016-12-15 2:58 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a2e0ee3-e8db-0e5f-3d0d-64f6e6bf367c@huawei.com \
--to=yuehaibing@huawei.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox